From: David Binderman <dcb314@hotmail.com>
To: "vladimir.mezentsev@oracle.com" <vladimir.mezentsev@oracle.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: bug in gprofng
Date: Wed, 21 Sep 2022 07:46:27 +0000 [thread overview]
Message-ID: <DB6P189MB0568837F30BD12979FE0087A9C4F9@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM> (raw)
Hello there Vladimir,
I just did a build of recent binutils with recent gcc. It said:
gprofng/src/collctrl.cc:763:12: warning: duplicated ‘if’ condition [-Wduplicated-cond]
Source code is
if (synctrace_thresh < 0)
*p++ = strdup ("calibrate");
else if (synctrace_thresh < 0)
*p++ = strdup ("all");
Suggest code rework.
Regards
David Binderman
next reply other threads:[~2022-09-21 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 7:46 David Binderman [this message]
2022-09-22 2:29 ` Vladimir Mezentsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6P189MB0568837F30BD12979FE0087A9C4F9@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM \
--to=dcb314@hotmail.com \
--cc=binutils@sourceware.org \
--cc=vladimir.mezentsev@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).