* bug in gprofng
@ 2022-09-21 7:46 David Binderman
2022-09-22 2:29 ` Vladimir Mezentsev
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2022-09-21 7:46 UTC (permalink / raw)
To: vladimir.mezentsev, binutils
Hello there Vladimir,
I just did a build of recent binutils with recent gcc. It said:
gprofng/src/collctrl.cc:763:12: warning: duplicated ‘if’ condition [-Wduplicated-cond]
Source code is
if (synctrace_thresh < 0)
*p++ = strdup ("calibrate");
else if (synctrace_thresh < 0)
*p++ = strdup ("all");
Suggest code rework.
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: bug in gprofng
2022-09-21 7:46 bug in gprofng David Binderman
@ 2022-09-22 2:29 ` Vladimir Mezentsev
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Mezentsev @ 2022-09-22 2:29 UTC (permalink / raw)
To: David Binderman, binutils
Hi David,
Thanks for finding this.
I just pushed my fix to the master branch.
-Vladimir
On 9/21/22 00:46, David Binderman wrote:
> Hello there Vladimir,
>
> I just did a build of recent binutils with recent gcc. It said:
>
> gprofng/src/collctrl.cc:763:12: warning: duplicated ‘if’ condition [-Wduplicated-cond]
>
> Source code is
>
> if (synctrace_thresh < 0)
> *p++ = strdup ("calibrate");
> else if (synctrace_thresh < 0)
> *p++ = strdup ("all");
>
> Suggest code rework.
>
> Regards
>
> David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-22 2:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 7:46 bug in gprofng David Binderman
2022-09-22 2:29 ` Vladimir Mezentsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).