public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Zhang, Jun" <jun.zhang@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
	"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH v3] Support Intel FRED LKGS
Date: Fri, 26 May 2023 10:02:55 +0000	[thread overview]
Message-ID: <DM4PR11MB60936F27D7CA15B790BC8472EA479@DM4PR11MB6093.namprd11.prod.outlook.com> (raw)
In-Reply-To: <16ce8023-86f5-d737-3a2f-c630e72b335e@suse.com>

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Friday, May 26, 2023 4:15 PM
> To: Zhang, Jun <jun.zhang@intel.com>
> Cc: hjl.tools@gmail.com; binutils@sourceware.org
> Subject: Re: [PATCH v3] Support Intel FRED LKGS
> 
> On 22.05.2023 16:20, Zhang, Jun wrote:
> > Hi all,
> >
> > This patch is the third version about Intel FRED and LKGS instructions.
> > please help to review.
> >
> > Jan,I am new comer, this is my first patch for binutils.
> > Maybe we need senior engineer to fix Ew.
> >
> > BRs,
> > Jun
> >
> > gas/ChangeLog:
> >
> >         * NEWS: Support Intel FRED LKGS.
> >         * config/tc-i386.c: Add fred lkgs
> >         * doc/c-i386.texi: Document .fred, .lkgs.
> >         * testsuite/gas/i386/i386.exp: Add FRED LKGS tests
> >         * testsuite/gas/i386/x86-64-fred-intel.d: Ditto.
> 
> This and ...
> 
> >         * testsuite/gas/i386/x86-64-fred.d: Ditto.
> >         * testsuite/gas/i386/x86-64-fred.s: Ditto.
> >         * testsuite/gas/i386/x86-64-lkgs-intel.d: Ditto.
> 
> ... this test ...
> 
> > --- a/gas/testsuite/gas/i386/i386.exp
> > +++ b/gas/testsuite/gas/i386/i386.exp
> > @@ -1189,6 +1189,9 @@ if [gas_64_check] then {
> >      run_dump_test "x86-64-amx-complex-intel"
> >      run_dump_test "x86-64-amx-complex-bad"
> >      run_list_test "x86-64-amx-complex-inval"
> > +    run_dump_test "x86-64-fred"
> > +    run_dump_test "x86-64-lkgs"
> > +    run_list_test "x86-64-lkgs-inval"
> >      run_dump_test "x86-64-clzero"
> >      run_dump_test "x86-64-mwaitx-bdver4"
> >      run_list_test "x86-64-mwaitx-reg"
> 
> .. aren't used. Both either want actually enabling or (less likely) deleting.

Sorry, I will submit a patch to fix it.

> 
> Jan

      reply	other threads:[~2023-05-26 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 14:20 Zhang, Jun
2023-05-22 14:46 ` Jan Beulich
2023-05-23  5:52   ` Hongtao Liu
2023-05-23  6:26     ` Jan Beulich
2023-05-23  6:45       ` Hongtao Liu
2023-05-26  8:14 ` Jan Beulich
2023-05-26 10:02   ` Zhang, Jun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB60936F27D7CA15B790BC8472EA479@DM4PR11MB6093.namprd11.prod.outlook.com \
    --to=jun.zhang@intel.com \
    --cc=JBeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).