From: Hongtao Liu <crazylht@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Zhang, Jun" <jun.zhang@intel.com>,
hjl.tools@gmail.com, binutils@sourceware.org
Subject: Re: [PATCH v3] Support Intel FRED LKGS
Date: Tue, 23 May 2023 13:52:28 +0800 [thread overview]
Message-ID: <CAMZc-by6X=otFg7VLt=mPAuJBf5QfYM6U7q_QK60_8n9rE=uKQ@mail.gmail.com> (raw)
In-Reply-To: <c9e558ce-424e-5f63-3616-1d0343313c7c@suse.com>
On Mon, May 22, 2023 at 10:47 PM Jan Beulich via Binutils
<binutils@sourceware.org> wrote:
>
> On 22.05.2023 16:20, Zhang, Jun wrote:
> > This patch is the third version about Intel FRED and LKGS instructions.
> > please help to review.
> >
> > Jan,I am new comer, this is my first patch for binutils.
> > Maybe we need senior engineer to fix Ew.
>
> Well, okay, I'll try to deal with that myself then. What I'm puzzled by
> though is what this v3 is intended to change / correct comparing to v2.
> The one small request about ...
>
> > --- a/opcodes/i386-opc.tbl
> > +++ b/opcodes/i386-opc.tbl
> > @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64
> > axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex }
> >
> > // RAO-INT instructions end.
> > +
> > +// LKGS instructions.
>
> ... using singular here and ...
>
> > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64, { Reg16|Reg32|Reg64 }
> > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf|No_qSuf, { Word|Unspecified|BaseIndex }
> > +
> > +// LKGS instructions end.
>
> ... here was not fulfilled, in any event. Plus that wouldn't require
> re-posting, but simply correcting before/while committing. In case
> you don't have commit access (you didn't say so, though) I'm sure
> H.J. or I could make this small adjustment while committing for you.
> But you'd need to let us know ...
Push to trunk on behalf of jun.
>
> Jan
--
BR,
Hongtao
next prev parent reply other threads:[~2023-05-23 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:20 Zhang, Jun
2023-05-22 14:46 ` Jan Beulich
2023-05-23 5:52 ` Hongtao Liu [this message]
2023-05-23 6:26 ` Jan Beulich
2023-05-23 6:45 ` Hongtao Liu
2023-05-26 8:14 ` Jan Beulich
2023-05-26 10:02 ` Zhang, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZc-by6X=otFg7VLt=mPAuJBf5QfYM6U7q_QK60_8n9rE=uKQ@mail.gmail.com' \
--to=crazylht@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jbeulich@suse.com \
--cc=jun.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).