From: Fangrui Song <i@maskray.me>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: Commit: Add support for displaying unicode characters
Date: Sat, 7 May 2022 22:46:26 -0700 [thread overview]
Message-ID: <DS7PR12MB576532695BA85B0A93443EEECBC79@DS7PR12MB5765.namprd12.prod.outlook.com> (raw)
In-Reply-To: <87v9115um8.fsf@redhat.com>
On Tue, Nov 9, 2021 at 5:25 AM Nick Clifton via Binutils
<binutils@sourceware.org> wrote:
>
> Hi Guys,
>
> I am applying the attached patch to add the ability to display unicode
> characters to the nm, strings, objdump and readelf tools. This is
> part of a response to the Trojan Source vulnerability that was
> recently disclosed. I am also working on a separate patch for gas,
> but that is not quite ready yet.
>
> Cheers
> Nick
>
> binutils/ChangeLog
> 2021-11-09 Nick Clifton <nickc@redhat.com>
>
> * nm.c: Add --unicode option to control how unicode characters are
> handled.
> * objdump.c: Likewise.
> * readelf.c: Likewise.
> * strings.c: Likewise.
> * binutils.texi: Document the new feature.
> * NEWS: Document the new feature.
> * testsuite/binutils-all/unicode.exp: New file.
> * testsuite/binutils-all/nm.hex.unicode
> * testsuite/binutils-all/strings.escape.unicode
> * testsuite/binutils-all/objdump.highlight.unicode
> * testsuite/binutils-all/readelf.invalid.unicode
>
I just learned that this patch added -U as an alias for --unicode. In
macOS nm and llvm-nm, -U is an alias for --defined-only.
--defined-only seems much more useful than --unicode. I wonder if it
is too late to redefine -U as --defined-only...
(On the llvm-nm side, I have filed
https://github.com/llvm/llvm-project/issues/55297 .
If it needs to keep compatibility with GNU nm, it will need to drop -U....)
next prev parent reply other threads:[~2022-05-08 5:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 13:25 Nick Clifton
2021-11-10 0:42 ` Alan Modra
2021-11-15 13:21 ` Nick Clifton
2022-05-08 5:46 ` Fangrui Song [this message]
[not found] ` <DS7PR12MB5765635B31F15184375B9140CBC79@DS7PR12MB5765.namprd12.prod.outlook.com>
2022-05-09 16:26 ` Nick Clifton
2022-05-10 4:21 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS7PR12MB576532695BA85B0A93443EEECBC79@DS7PR12MB5765.namprd12.prod.outlook.com \
--to=i@maskray.me \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).