public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Fangrui Song <i@maskray.me>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] ld: Output error for linker warnings with --fatal-warnings
Date: Fri, 26 Jan 2024 11:20:29 -0800	[thread overview]
Message-ID: <DS7PR12MB5765936B7C4D17F6708B6A2FCB792@DS7PR12MB5765.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240126185652.3464023-2-hjl.tools@gmail.com>

On Fri, Jan 26, 2024 at 10:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Since --fatal-warnings changes warnings into errors, we should output
> error, instead of warning, for linker warnings.
>
> Add %w to vfinfo to output "warning" if --fatal-warnings isn't used or
> "error" otherwise.  Replace warning with %w in linker warnings.

Thanks for the patch! This will be a great improvement.

  reply	other threads:[~2024-01-26 19:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 18:56 [PATCH 0/2] ld: Output error for " H.J. Lu
2024-01-26 18:56 ` [PATCH 1/2] ld: Output error for linker " H.J. Lu
2024-01-26 19:20   ` Fangrui Song [this message]
2024-01-26 18:56 ` [PATCH 2/2] bfd: Output error for linker --fatal-warnings option H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DS7PR12MB5765936B7C4D17F6708B6A2FCB792@DS7PR12MB5765.namprd12.prod.outlook.com \
    --to=i@maskray.me \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).