[PATCH] Descriptive DWARF operations dump support for DW_AT_rank

[PATCH] Descriptive DWARF operations dump support for DW_AT_rank

[Kumar N, Bhuvanendra]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

[Public]

Hi,

This is a one line patch to support descriptive dwarf operations dump for DW_AT_rank attribute introduced in dwarf-5 for specific fortran array.

Before fix: DW_AT_rank        : 6 byte block: 97 23 8 6 37 1a
---
After fix:   DW_AT_rank        : 6 byte block: 97 23 8 6 37 1a         (DW_OP_push_object_address; DW_OP_plus_uconst: 8; DW_OP_deref; DW_OP_lit7; DW_OP_and)

Patch inlined:

From e08c6f5321dafad4cf6a25e5dcb7c1dd84c9f90b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9Cbhkumarn=E2=80=9D?= Bhuvanendra.KumarN@amd.com<mailto:Bhuvanendra.KumarN@amd.com>
Date: Wed, 15 Jun 2022 14:17:27 +0530
Subject: [PATCH] [PATCH] Descriptive DWARF operations dump support for
DW_AT_rank

DW_AT_rank is a dwarf-5 feature.

Change-Id: I77f6c081c64427833439f124be0b251dff104c83
---
binutils/dwarf.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index beb69544e38..2b1eec49422 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -3376,6 +3376,7 @@ read_and_display_attr_value (unsigned long           attribute,
     case DW_AT_stride:
     case DW_AT_upper_bound:
     case DW_AT_lower_bound:
+    case DW_AT_rank:
       if (block_start)
     {
       int need_frame_base;
--
2.17.1




[-- Attachment #2: 0001-PATCH-Descriptive-DWARF-operations-dump-support-for-.patch --]
[-- Type: application/octet-stream, Size: 803 bytes --]

From e08c6f5321dafad4cf6a25e5dcb7c1dd84c9f90b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9Cbhkumarn=E2=80=9D?= <Bhuvanendra.KumarN@amd.com>
Date: Wed, 15 Jun 2022 14:17:27 +0530
Subject: [PATCH] [PATCH] Descriptive DWARF operations dump support for
 DW_AT_rank

DW_AT_rank is a dwarf-5 feature.

Change-Id: I77f6c081c64427833439f124be0b251dff104c83
---
 binutils/dwarf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index beb69544e38..2b1eec49422 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -3376,6 +3376,7 @@ read_and_display_attr_value (unsigned long           attribute,
     case DW_AT_stride:
     case DW_AT_upper_bound:
     case DW_AT_lower_bound:
+    case DW_AT_rank:
       if (block_start)
 	{
 	  int need_frame_base;
-- 
2.17.1

Re: [PATCH] Descriptive DWARF operations dump support for DW_AT_rank

[Nick Clifton]

Hi Kumar,

> This is a one line patch to support descriptive dwarf operations dump for DW_AT_rank attribute introduced in dwarf-5 for specific fortran array.

Approved - please apply.

Cheers
   Nick

RE: [PATCH] Descriptive DWARF operations dump support for DW_AT_rank

[Kumar N, Bhuvanendra]

[AMD Official Use Only - General]

Thanks, I pushed the fix now

commit ad349f2493f934573c0809ead35ea299286beecd (HEAD -> master, origin/master, origin/HEAD)
Author: Bhuvanendra Kumar N <Bhuvanendra.KumarN@amd.com>
Date:   Wed Jul 6 16:26:25 2022 +0530

    Descriptive DWARF operations dump support for DW_AT_rank

    DW_AT_rank is a dwarf-5 feature.

-----Original Message-----
From: Nick Clifton <nickc@redhat.com> 
Sent: Wednesday, July 6, 2022 1:39 PM
To: Kumar N, Bhuvanendra <Bhuvanendra.KumarN@amd.com>; binutils@sourceware.org
Cc: George, Jini Susan <JiniSusan.George@amd.com>; Natarajan, Kavitha <Kavitha.Natarajan@amd.com>
Subject: Re: [PATCH] Descriptive DWARF operations dump support for DW_AT_rank

[CAUTION: External Email]

Hi Kumar,

> This is a one line patch to support descriptive dwarf operations dump for DW_AT_rank attribute introduced in dwarf-5 for specific fortran array.

Approved - please apply.

Cheers
   Nick