public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Fangrui Song <i@maskray.me>
To: Alan Modra <amodra@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: PowerPC64 DT_RELR
Date: Tue, 8 Mar 2022 17:25:08 -0800	[thread overview]
Message-ID: <MWHPR1201MB0110F5B9FEAC15EB1FB7D883CB0A9@MWHPR1201MB0110.namprd12.prod.outlook.com> (raw)
In-Reply-To: <Yh8trlsqq+dSjZQa@squeak.grove.modra.org>

On Wed, Mar 2, 2022 at 12:41 AM Alan Modra via Binutils
<binutils@sourceware.org> wrote:
>
> I had a look today at DT_RELR again, and found I need to do some work
> in the linker.  Just keeping addresses of relative relocs isn't
> enough, because data addresses can change between ppc64_elf_size_stubs
> and ppc64_elf_build_stubs.  Anyway, the reason for the email is to
> inform anyone playing with DT_RELR on powerpc64 that the current
> support is definitely experimental!  Also, you might like to apply the
> attached patch to gitlab.com/x86-glibc/glibc users/hjl/relr/master
> branch.  glibc regressions went from 574 to 17.
>
> --
> Alan Modra
> Australia Development Lab, IBM

Thanks for testing it on PowerPC. It seems cleaner to fold
0006-elf-ELF_DYNAMIC_RELOCATE-order-relr-before-rel-rela.patch  into
patch 1.
I adjusted my https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/maskray/relr

H.J. may adjust
https://sourceware.org/pipermail/libc-alpha/2022-March/136783.html
("[PATCH v5 1/5] elf: Support DT_RELR relative relocation format [BZ #27924]")

HJ's series looks good to me
(https://sourceware.org/pipermail/libc-alpha/2022-March/136784.html).

  parent reply	other threads:[~2022-03-09  1:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  0:53 Alan Modra
2022-01-18  1:08 ` H.J. Lu
2022-01-18 13:32   ` H.J. Lu
2022-01-18 23:24     ` Alan Modra
2022-01-19 22:56       ` H.J. Lu
2022-01-22  4:28         ` Alan Modra
2022-01-22 13:04           ` H.J. Lu
2022-01-23 13:51           ` H.J. Lu
2022-03-02  8:41             ` Alan Modra
2022-03-03  2:33               ` PowerPC64 DT_RELR relative reloc addresses Alan Modra
2022-03-09  1:25               ` Fangrui Song [this message]
     [not found]               ` <MWHPR1201MB0110441CD99C43F8215D15EBCB0A9@MWHPR1201MB0110.namprd12.prod.outlook.com>
2022-03-09 21:07                 ` PowerPC64 DT_RELR Alan Modra
2022-06-09 10:57 ` Florian Weimer
2022-06-09 22:57   ` Alan Modra
2022-06-09 23:53     ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR1201MB0110F5B9FEAC15EB1FB7D883CB0A9@MWHPR1201MB0110.namprd12.prod.outlook.com \
    --to=i@maskray.me \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).