public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Alan Modra via Binutils <binutils@sourceware.org>,
	Nick Clifton <nickc@redhat.com>
Subject: Re: PowerPC64 DT_RELR
Date: Fri, 10 Jun 2022 08:27:24 +0930	[thread overview]
Message-ID: <YqJ61Pl+ypKKmYXb@squeak.grove.modra.org> (raw)
In-Reply-To: <871qvy5ckj.fsf@oldenburg.str.redhat.com>

On Thu, Jun 09, 2022 at 12:57:32PM +0200, Florian Weimer wrote:
> * Alan Modra via Binutils:
> 
> > PowerPC64 takes a more traditional approach to DT_RELR than x86.  Count
> > relative relocs in check_relocs, allocate space for them and output in
> > the usual places but not doing so when enable_dt_relr.  DT_RELR is
> > sized in the existing ppc stub relaxation machinery, run via the
> > linker's ldemul_after_allocation hook.  DT_RELR is output in the same
> > function that writes ppc stubs, run via ldemul_finish.
> >
> > This support should be considered experimental.
> 
> Upstream glibc enables DT_RELR for its ELF files by default (including
> tests), and we seem to hit something DT_RELR-related:
> 
>   Some glibc tests crash in DT_RELR relocation on powerpc64le
>   <https://sourceware.org/bugzilla/show_bug.cgi?id=29235>
> 
> (I'm working on attaching the test binary to the bug.)

I'll investigate.  My guess would be .eh_frame editing is the trigger.

> Maybe we should not automatically DT_RELR for glibc itself if BFD ld
> supports it?

Yes, at least until I can fix this.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2022-06-09 22:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  0:53 Alan Modra
2022-01-18  1:08 ` H.J. Lu
2022-01-18 13:32   ` H.J. Lu
2022-01-18 23:24     ` Alan Modra
2022-01-19 22:56       ` H.J. Lu
2022-01-22  4:28         ` Alan Modra
2022-01-22 13:04           ` H.J. Lu
2022-01-23 13:51           ` H.J. Lu
2022-03-02  8:41             ` Alan Modra
2022-03-03  2:33               ` PowerPC64 DT_RELR relative reloc addresses Alan Modra
2022-03-09  1:25               ` PowerPC64 DT_RELR Fangrui Song
     [not found]               ` <MWHPR1201MB0110441CD99C43F8215D15EBCB0A9@MWHPR1201MB0110.namprd12.prod.outlook.com>
2022-03-09 21:07                 ` Alan Modra
2022-06-09 10:57 ` Florian Weimer
2022-06-09 22:57   ` Alan Modra [this message]
2022-06-09 23:53     ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqJ61Pl+ypKKmYXb@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).