From: "Jiang, Haochen" <haochen.jiang@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler
Date: Tue, 6 Dec 2022 08:00:28 +0000 [thread overview]
Message-ID: <SA1PR11MB5946624FFF7A39E254F1B79AEC1B9@SA1PR11MB5946.namprd11.prod.outlook.com> (raw)
In-Reply-To: <90dc84c9-7bef-d3da-f949-7b03ce8ac4f8@suse.com>
> On 06.12.2022 02:36, Jiang, Haochen wrote:
> >>> Another reason for removing this check is because xh_mode with
> >>> broadcast usage should not indicate the vex.w bit. Instead it should
> >>> be handled by a W table entry.
> >>
> >> There are no broadcast insns using xh_mode, and you can't really mean
> >> embedded broadcast (because EVEX.W needs to be properly encoded
> >> there).
> >> Hence I don't follow what you're talking about here.
> >
> > Maybe this part is a little misleading. I will delete that in commit message.
> > What I actually mean is just like what you commented.
> >
> > I suppose using a W table entry in the future to encode here if not
> > using something like %XH.
>
> Feel free to commit with that text dropped; aiui you've addressed H.J.'s
> question.
Ok. I will commit the patch with that text dropped.
Thanks for your review!
Haochen
>
> Jan
prev parent reply other threads:[~2022-12-06 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 2:53 Haochen Jiang
2022-12-05 11:16 ` Jan Beulich
2022-12-06 1:36 ` Jiang, Haochen
2022-12-06 3:39 ` H.J. Lu
2022-12-06 6:14 ` Jiang, Haochen
2022-12-06 7:29 ` Jan Beulich
2022-12-06 8:00 ` Jiang, Haochen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5946624FFF7A39E254F1B79AEC1B9@SA1PR11MB5946.namprd11.prod.outlook.com \
--to=haochen.jiang@intel.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).