From: Jan Beulich <jbeulich@suse.com>
To: Haochen Jiang <haochen.jiang@intel.com>
Cc: hjl.tools@gmail.com, binutils@sourceware.org
Subject: Re: [PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler
Date: Mon, 5 Dec 2022 12:16:02 +0100 [thread overview]
Message-ID: <18459a42-b4a4-00b0-b00d-04ce01b1de34@suse.com> (raw)
In-Reply-To: <20221205025311.73743-1-haochen.jiang@intel.com>
On 05.12.2022 03:53, Haochen Jiang wrote:
> For all the xh_mode usage in table, they are all using %XH, which will
> print "{bad}" while EVEX.W=1. This makes this vex.w check unnecessary.
I agree with this part.
> Another reason for removing this check is because xh_mode with
> broadcast usage should not indicate the vex.w bit. Instead it should
> be handled by a W table entry.
There are no broadcast insns using xh_mode, and you can't really mean
embedded broadcast (because EVEX.W needs to be properly encoded there).
Hence I don't follow what you're talking about here.
The code change is okay, but if the above is to become the commit
message, the raised question will need addressing first.
Jan
next prev parent reply other threads:[~2022-12-05 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 2:53 Haochen Jiang
2022-12-05 11:16 ` Jan Beulich [this message]
2022-12-06 1:36 ` Jiang, Haochen
2022-12-06 3:39 ` H.J. Lu
2022-12-06 6:14 ` Jiang, Haochen
2022-12-06 7:29 ` Jan Beulich
2022-12-06 8:00 ` Jiang, Haochen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18459a42-b4a4-00b0-b00d-04ce01b1de34@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).