RE: [PATCH V4] Support APX NF

["Cui, Lili" <lili.cui@intel.com>]

> On 26.03.2024 07:49, Cui, Lili wrote:
> > --- a/gas/testsuite/gas/i386/x86-64-apx-inval.s
> > +++ b/gas/testsuite/gas/i386/x86-64-apx-inval.s
> > @@ -2,3 +2,12 @@
> >  	.text
> >  	addq $0xe0, %fs:0, %rdx
> >  	xorq $0xe0, foo(%eax,%edx), %rdx
> > +	{nf} adc $1, (%rax)
> > +	{nf} not %r15
> > +	{nf} rcl $0x7b,%r15
> > +	{nf} rcr $0x7b,%r15
> > +	{nf} sbb $0x7b,%r15
> > +	{nf} pop2 %rax, %rbx
> > +	{nf} push2 %rbx, %rax
> 
> I think it would be nice if one of ADCX/ADOX and at least one of the BMI2
> insns not permitting NF would also be covered here.
> 

Done.

> > --- /dev/null
> > +++ b/gas/testsuite/gas/i386/x86-64-apx-nf-intel.d
> > @@ -0,0 +1,1383 @@
> > +#as:
> > +#objdump: -dw -Mintel
> > +#name: x86_64 APX_F insns (Intel disassembly)
> 
> Here, ...
> 
> > --- /dev/null
> > +++ b/gas/testsuite/gas/i386/x86-64-apx-nf.d
> > @@ -0,0 +1,1383 @@
> > +#as:
> > +#objdump: -dw
> > +#name: x86_64 APX_F insns
> 
> ... here, and ...
> 
> > --- /dev/null
> > +++ b/gas/testsuite/gas/i386/x86-64-apx-nf.s
> > @@ -0,0 +1,1378 @@
> > +# Check 64bit APX_F instructions
> 
> ... in this comment NF wants mentioning.
> 

Done.

> > +	{nf}	blsmsk	%ecx, %edx
> > +	{nf}	blsmsk	%r9, %r31
> > +	{nf}	blsmsk	291(%r8, %rax, 4), %ecx
> > +	{nf}	blsmsk	291(%r8, %rax, 4), %r9
> > +	{nf}	blsr	%ecx, %edx
> > +	{nf}	blsr	%r9, %r31
> > +	{nf}	blsr	291(%r8, %rax, 4), %ecx
> > +	{nf}	blsr	291(%r8, %rax, 4), %r9
> > +	{nf}	bzhi	%ecx, %edx, %r10d
> > +	{nf}	bzhi	%ecx, 291(%r8, %rax, 4), %edx
> > +	{nf}	bzhi	%r9, %r31, %r11
> > +	{nf}	bzhi	%r9, 291(%r8, %rax, 4), %r31
> > +	{nf}	dec	%bl
> 
> No CLR test here? Oh, I see it's at the bottom. I wants moving here.
>
 
Done.

Thanks,
Lili.