From: "Cui, Lili" <lili.cui@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
"hjl.tools@gmail.com" <hjl.tools@gmail.com>
Subject: RE: [PATCH] Support {evex} pseudo prefix for decode evex promoted insns without egpr32.
Date: Thu, 21 Mar 2024 12:33:37 +0000 [thread overview]
Message-ID: <SJ0PR11MB5600D3B850C236A4D32AF75E9E322@SJ0PR11MB5600.namprd11.prod.outlook.com> (raw)
In-Reply-To: <96e2e203-4778-444a-a13a-e35a48ce12ae@suse.com>
> >>> --- /dev/null
> >>> +++ b/gas/testsuite/gas/i386/x86-64-apx_f-evex.s
> >>> @@ -0,0 +1,1192 @@
> >>> +# Check 64bit APX_F instructions with evex pseudo prefix
> >>> +
> >>> + {evex} imul %r15
> >>> + {evex} imul %r15,%r15
> >>> + {evex} imul %r15d
> >>> + {evex} imul %r15d,%edx
> >>> + {evex} imul %r15w
> >>> + {evex} imul %r15w,%ax
> >>> + {evex} imul %r8b
> >>> + {evex} imulb 0x123(%r8,%rax,4)
> >>> + {evex} imulw 0x123(%r8,%rax,4)
> >>> + {evex} imull 0x123(%r8,%rax,4)
> >>> + {evex} imul 0x123(%r8,%rax,4),%r15
> >>> + {evex} imul 0x123(%r8,%rax,4),%r15d
> >>> + {evex} imul 0x123(%r8,%rax,4),%r15w
> >>> + {evex} imulq 0x123(%r8,%rax,4)
> >>> + {evex} imul $0x7b, %dx, %ax
> >>> + {evex} imul $0x7b, %ecx, %edx
> >>> + {evex} imul $0x7b, %r9, %r15
> >>> + {evex} imul $0x7b, 291(%r8, %rax, 4), %dx
> >>> + {evex} imul $0x7b, 291(%r8, %rax, 4), %ecx
> >>> + {evex} imul $0x7b, 291(%r8, %rax, 4), %r9
> >>> + {evex} imul $0xff90, %dx, %ax
> >>> + {evex} imul $0xff90, %ecx, %edx
> >>> + {evex} imul $0xff90, %r9, %r15
> >>> + {evex} imul $0xff90, 291(%r8, %rax, 4), %dx
> >>> + {evex} imul $0xff90, 291(%r8, %rax, 4), %ecx
> >>> + {evex} imul $0xff90, 291(%r8, %rax, 4), %r9
> >>
> >> Also covering the 2-operand forms of these (srcreg == dstreg) would
> >> seem desirable.
> >
> > I'm a little confused here, do you suggest adding such a testcase?
> >
> > {evex} imul $0x7b, %r9, %r9
>
> That's still 3 operands. What I mean is
>
> {evex} imul $0x7b, %r9
>
> , again for the reason of that being covered by a separate insn template.
>
> Jan
Oh, I see why, I didn't promote the 2-operand form of imul in the nf patch, which means we also need to enable ZU for them as well.
// imul with 2 operands mimics imul with 3 by putting the register in
// both i.rm.reg & i.rm.regmem fields. RegKludge enables this
// transformation.
imul, 0x6b, i186, Modrm|No_bSuf|No_sSuf|RegKludge, { Imm8S, Reg16|Reg32|Reg64 }
imul, 0x69, i186, Modrm|No_bSuf|No_sSuf|RegKludge, { Imm16|Imm32|Imm32S, Reg16|Reg32|Reg64 }
Thanks,
Lili.
next prev parent reply other threads:[~2024-03-21 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:58 Cui, Lili
2024-03-08 10:37 ` Jan Beulich
2024-03-20 13:12 ` Cui, Lili
2024-03-20 13:21 ` Jan Beulich
2024-03-21 12:33 ` Cui, Lili [this message]
2024-03-22 9:45 ` Cui, Lili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5600D3B850C236A4D32AF75E9E322@SJ0PR11MB5600.namprd11.prod.outlook.com \
--to=lili.cui@intel.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).