From: "Hu, Lin1" <lin1.hu@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>
Cc: "Lu, Hongjiu" <hongjiu.lu@intel.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH][v6] Support Intel USER_MSR
Date: Tue, 31 Oct 2023 08:35:21 +0000 [thread overview]
Message-ID: <SJ0PR11MB5940BDF4F09DDF586CF6CE69A6A0A@SJ0PR11MB5940.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ecde3a07-fa57-c3d2-eefd-305af87460bb@suse.com>
> On 31.10.2023 03:14, Hu, Lin1 wrote:
> > This is the current version.
> >
> > BRs,
> > Lin
> >
> > gas/ChangeLog:
> >
> > * NEWS: Support Intel USER_MSR.
> > * config/tc-i386.c (smallest_imm_type): Reject imm32 in 64bit
> > mode.
> > (build_vex_prefix): Add VEXMAP7.
> > (md_assemble): Handling the imm32 of USER_MSR.
> > (match_template): Handling the unusual immediate.
> > * doc/c-i386.texi: Document .user_msr.
> > * testsuite/gas/i386/i386.exp: Run USER_MSR tests.
> > * testsuite/gas/i386/x86-64.exp: Ditto.
> > * testsuite/gas/i386/user_msr-inval.l: New test.
> > * testsuite/gas/i386/user_msr-inval.s: Ditto.
> > * testsuite/gas/i386/x86-64-user_msr-intel.d: Ditto.
> > * testsuite/gas/i386/x86-64-user_msr-inval.l: New test.
> > * testsuite/gas/i386/x86-64-user_msr-inval.s: New test.
> > * testsuite/gas/i386/x86-64-user_msr.d: Ditto.
> > * testsuite/gas/i386/x86-64-user_msr.s: Ditto.
> >
> > opcodes/ChangeLog:
> > * i386-dis.c (struct instr_info): Add a new attribute
> > has_skipped_modrm.
> > (Gq): New.
> > (Rq): Ditto.
> > (q_mm_mode): Ditto.
> > (Nq): Change mode from q_mode to q_mm_mode.
> > (VEX_LEN_TABLE):
> > (get_valid_dis386): Add VEX_MAP7 in VEX prefix.
> > and handle the map7_f8 for save space.
> > (OP_Skip_MODRM): Set has_skipped_modrm.
> > (OP_E): Skip codep++ when has skipped modrm byte.
> > (OP_R): Support q_mode and q_mm_mode.
> > (REG_VEX_MAP7_F8_L_0_W_0): New.
> > (PREFIX_VEX_MAP7_F8_L_0_W_0_R_0_X86_64): Ditto.
> > (X86_64_VEX_MAP7_F8_L_0_W_0_R_0): Ditto.
> > (VEX_LEN_MAP7_F8): Ditto.
> > (VEX_W_MAP7_F8_L_0): Ditto.
> > (MOD_0F38F8): Ditto.
> > (PREFIX_0F38F8_M_0): Ditto.
> > (PREFIX_0F38F8_M_1_X86_64): Ditto.
> > (X86_64_0F38F8_M_1): Ditto.
> > (PREFIX_0F38F8): Remove.
> > (prefix_table): Add PREFIX_0F38F8_M_1_X86_64.
> > Remove PREFIX_0F38F8.
> > (reg_table): Add REG_VEX_MAP7_F8_L_0_W_0,
> > PREFIX_VEX_MAP7_F8_L_0_W_0_R_0_X86_64.
> > (x86_64_table): Add X86_64_0F38F8_PREFIX_3_M_1,
> > X86_64_VEX_MAP7_F8_L_0_W_0_R_0 and X86_64_0F38F8_M_1.
> > (vex_table): Add VEX_MAP7.
> > (vex_len_table): Add VEX_LEN_MAP7_F8,
> > VEX_W_MAP7_F8_L_0.
> > (mod_table): New entry for USER_MSR and
> > add MOD_0F38F8.
> > * i386-gen.c (cpu_flag_init): Add CPU_USER_MSR_FLAGS and
> > CPU_ANY_USER_MSR_FLAGS. Add add VEXMAP7.
> > * i386-init.h: Regenerated.
> > * i386-mnem.h: Ditto.
> > * i386-opc.h (SPACE_VEXMAP7): New.
> > (CPU_USER_MSR_FLAGS): Ditoo.
> > (CPU_ANY_USER_MSR_FLAGS): Ditto.
> > (i386_cpu_flags): Add cpuuser_msr.
> > * i386-opc.tbl: Add USER_MSR instructions.
> > * i386-tbl.h: Regenerated.
>
> Okay. Going forward though please make sure that patches have a useful
> description (beyond the ChangeLog entries).
Thanks, have changed descriptions and upstreamed to the master branch.
BRs,
Lin
next prev parent reply other threads:[~2023-10-31 8:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 7:24 [PATCH] " Hu, Lin1
2023-10-16 12:11 ` Jan Beulich
2023-10-18 7:51 ` Hu, Lin1
2023-10-19 8:36 ` Jan Beulich
2023-10-24 8:38 ` Hu, Lin1
2023-10-24 8:55 ` Jan Beulich
2023-10-24 10:01 ` Hu, Lin1
2023-10-24 12:02 ` Jan Beulich
2023-10-25 2:01 ` Hu, Lin1
2023-10-25 8:48 ` Jan Beulich
2023-10-25 9:11 ` [PATCH][v3] " Hu, Lin1
2023-10-25 11:43 ` Jan Beulich
2023-10-26 6:14 ` Hu, Lin1
2023-10-26 6:21 ` [PATCH][v4] " Hu, Lin1
2023-10-26 8:31 ` Jan Beulich
2023-10-26 9:08 ` Hu, Lin1
2023-10-26 9:25 ` Jan Beulich
2023-10-26 10:26 ` Hu, Lin1
2023-10-27 9:00 ` [PATCH][v5] " Hu, Lin1
2023-10-27 13:36 ` Jan Beulich
2023-10-30 5:50 ` Hu, Lin1
2023-10-30 8:31 ` Jan Beulich
2023-10-31 1:43 ` Hu, Lin1
2023-10-31 2:14 ` [PATCH][v6] " Hu, Lin1
2023-10-31 8:03 ` Jan Beulich
2023-10-31 8:35 ` Hu, Lin1 [this message]
2023-11-14 7:14 ` Jan Beulich
2023-11-15 3:09 ` Hu, Lin1
2023-11-15 3:34 ` Jiang, Haochen
2023-11-15 7:36 ` Jan Beulich
2023-11-15 7:41 ` Jiang, Haochen
2023-11-15 7:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5940BDF4F09DDF586CF6CE69A6A0A@SJ0PR11MB5940.namprd11.prod.outlook.com \
--to=lin1.hu@intel.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hongjiu.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).