From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: In-memory nested archives
Date: Mon, 20 Feb 2023 12:26:51 +1030 [thread overview]
Message-ID: <Y/LTY//irZ06TbCl@squeak.grove.modra.org> (raw)
alpha-linuxecoff has compressed archives that are decompressed to a
bfd-in-memory. We'd need to handle quite a lot of corner cases to
support nesting of such archives, so just stop it before we run into
segfaults later.
* opncls.c (_bfd_new_bfd_contained_in): Prohibit nested
archives in memory.
diff --git a/bfd/opncls.c b/bfd/opncls.c
index eeac5825dbf..f0f4ed55ca4 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -103,6 +103,12 @@ _bfd_new_bfd_contained_in (bfd *obfd)
{
bfd *nbfd;
+ /* Nested archives in bims are unsupported. */
+ if ((obfd->flags & BFD_IN_MEMORY) != 0)
+ {
+ bfd_set_error (bfd_error_malformed_archive);
+ return NULL;
+ }
nbfd = _bfd_new_bfd ();
if (nbfd == NULL)
return NULL;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-02-20 10:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/LTY//irZ06TbCl@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).