public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* In-memory nested archives
@ 2023-02-20  1:56 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-02-20  1:56 UTC (permalink / raw)
  To: binutils

alpha-linuxecoff has compressed archives that are decompressed to a
bfd-in-memory.  We'd need to handle quite a lot of corner cases to
support nesting of such archives, so just stop it before we run into
segfaults later.

	* opncls.c (_bfd_new_bfd_contained_in): Prohibit nested
	archives in memory.

diff --git a/bfd/opncls.c b/bfd/opncls.c
index eeac5825dbf..f0f4ed55ca4 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -103,6 +103,12 @@ _bfd_new_bfd_contained_in (bfd *obfd)
 {
   bfd *nbfd;
 
+  /* Nested archives in bims are unsupported.  */
+  if ((obfd->flags & BFD_IN_MEMORY) != 0)
+    {
+      bfd_set_error (bfd_error_malformed_archive);
+      return NULL;
+    }
   nbfd = _bfd_new_bfd ();
   if (nbfd == NULL)
     return NULL;

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-20 10:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-20  1:56 In-memory nested archives Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).