From: Alan Modra <amodra@gmail.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems
Date: Mon, 20 Feb 2023 21:22:56 +1030 [thread overview]
Message-ID: <Y/NRCHAam1CH0dxo@squeak.grove.modra.org> (raw)
In-Reply-To: <20230220082224.415968-1-chigot@adacore.com>
On Mon, Feb 20, 2023 at 09:22:21AM +0100, Clément Chigot via Binutils wrote:
> When dealing with case insensitive file systems, ".file line.s" and
> ".file Line.s" are identical and thus gas won't change the current
> input file.
> However, in line.l test, it's expecting to trigger an input file switch.
> As the second filename doesn't matter in it, change it to fit for those
> file systems.
I'm leaving this one to Jan to approve, because I suspect the capital
may have been a typo.
> gas/ChangeLog:
>
> * testsuite/gas/elf/line.l: Change Line.s to new_line.s.
> * testsuite/gas/elf/line.s: Adjust output.
> ---
> gas/testsuite/gas/elf/line.l | 12 ++++++------
> gas/testsuite/gas/elf/line.s | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/gas/testsuite/gas/elf/line.l b/gas/testsuite/gas/elf/line.l
> index 6fde80b7a85..f8511298bc1 100644
> --- a/gas/testsuite/gas/elf/line.l
> +++ b/gas/testsuite/gas/elf/line.l
> @@ -15,17 +15,17 @@ line\.s:[0-9]*23: Info: .*
> line\.s:4: Warning: m1/2: XYZ
> line\.s:[0-9]*23: Info: .*
> line\.s:[0-9]*24: Warning: \.warning .*
> -Line\.s:10: Warning: m2/1: 987
> +new_line\.s:10: Warning: m2/1: 987
> line\.s:[0-9]*26: Info: .*
> -Line\.s:12: Warning: m2/2: 987
> +new_line\.s:12: Warning: m2/2: 987
> line\.s:[0-9]*26: Info: .*
> -Line\.s:10: Warning: m2/1: zyx
> +new_line\.s:10: Warning: m2/1: zyx
> line\.s:[0-9]*27: Info: .*
> -Line\.s:12: Warning: m2/2: zyx
> +new_line\.s:12: Warning: m2/2: zyx
> line\.s:[0-9]*27: Info: .*
> -Line\.s:10: Warning: m2/1: CBA
> +new_line\.s:10: Warning: m2/1: CBA
> line\.s:[0-9]*28: Info: .*
> -Line\.s:12: Warning: m2/2: CBA
> +new_line\.s:12: Warning: m2/2: CBA
> line\.s:[0-9]*28: Info: .*
> line\.s:[0-9]*29: Warning: \.warning .*
> line\.s:[0-9]*35: Warning: irp/1: 123
> diff --git a/gas/testsuite/gas/elf/line.s b/gas/testsuite/gas/elf/line.s
> index 2190cc3c225..e3a97887d96 100644
> --- a/gas/testsuite/gas/elf/line.s
> +++ b/gas/testsuite/gas/elf/line.s
> @@ -5,7 +5,7 @@
> .endm
>
> .macro m2 args:vararg
> - .file "Line.s"
> + .file "new_line.s"
> .line 9
> .warning "m2/1: \args"
> .nop
> --
> 2.25.1
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2023-02-20 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:22 Clément Chigot
2023-02-20 8:22 ` [PATCH 2/4] ld/testsuite: don't output to /dev/null on mingw hosts Clément Chigot
2023-02-20 10:59 ` Alan Modra
2023-02-20 8:22 ` [PATCH 3/4] ld/testsuite: adjust to Windows path separator Clément Chigot
2023-02-20 11:00 ` Alan Modra
2023-02-20 8:22 ` [PATCH 4/4] ld/testsuite: handle Windows drive letter in a noinit test Clément Chigot
2023-02-20 11:02 ` Alan Modra
2023-02-20 10:52 ` Alan Modra [this message]
2023-02-21 8:30 ` [PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems Jan Beulich
2023-02-21 8:40 ` Jan Beulich
2023-02-21 9:02 ` Clément Chigot
2023-02-21 9:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/NRCHAam1CH0dxo@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).