From: Jan Beulich <jbeulich@suse.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems
Date: Tue, 21 Feb 2023 09:40:55 +0100 [thread overview]
Message-ID: <ecce4d65-f42f-e44c-72f2-405ec3278a19@suse.com> (raw)
In-Reply-To: <20230220082224.415968-1-chigot@adacore.com>
On 20.02.2023 09:22, Clément Chigot via Binutils wrote:
> When dealing with case insensitive file systems, ".file line.s" and
> ".file Line.s" are identical and thus gas won't change the current
> input file.
> However, in line.l test, it's expecting to trigger an input file switch.
> As the second filename doesn't matter in it, change it to fit for those
> file systems.
>
> gas/ChangeLog:
>
> * testsuite/gas/elf/line.l: Change Line.s to new_line.s.
Since I have a pretty sincere dislike for underscores in filenames, may
I ask that you use e.g. line2.s or even (preserving original case)
Line2.s? Other than that I'm okay with the change, albeit I'd like to
point out that libiberty's filename_cmp() isn't really international-
ready (works reliably only for ASCII), and hence there are apparently
bigger issues here. Plus file system properties cannot really be a build-
time constraint, as there could be a mix that is in use.
Jan
next prev parent reply other threads:[~2023-02-21 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:22 Clément Chigot
2023-02-20 8:22 ` [PATCH 2/4] ld/testsuite: don't output to /dev/null on mingw hosts Clément Chigot
2023-02-20 10:59 ` Alan Modra
2023-02-20 8:22 ` [PATCH 3/4] ld/testsuite: adjust to Windows path separator Clément Chigot
2023-02-20 11:00 ` Alan Modra
2023-02-20 8:22 ` [PATCH 4/4] ld/testsuite: handle Windows drive letter in a noinit test Clément Chigot
2023-02-20 11:02 ` Alan Modra
2023-02-20 10:52 ` [PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems Alan Modra
2023-02-21 8:30 ` Jan Beulich
2023-02-21 8:40 ` Jan Beulich [this message]
2023-02-21 9:02 ` Clément Chigot
2023-02-21 9:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecce4d65-f42f-e44c-72f2-405ec3278a19@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).