* PR29720, objdump -S crashes if build-id is missing
@ 2022-10-26 5:07 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2022-10-26 5:07 UTC (permalink / raw)
To: binutils
PR 29720
* objdump.c (slurp_file): Don't call debuginfod_find_source
when build_id is NULL.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index f7b4695c3e8..a4ab0dbd66c 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -1879,17 +1879,19 @@ slurp_file (const char * fn,
#if HAVE_LIBDEBUGINFOD
if (fd < 0 && use_debuginfod && fn[0] == '/' && abfd != NULL)
{
- unsigned char * build_id;
- debuginfod_client * client;
+ unsigned char *build_id = get_build_id (abfd);
- client = debuginfod_begin ();
- if (client == NULL)
- return NULL;
+ if (build_id)
+ {
+ debuginfod_client *client = debuginfod_begin ();
- build_id = get_build_id (abfd);
- fd = debuginfod_find_source (client, build_id, 0, fn, NULL);
- free (build_id);
- debuginfod_end (client);
+ if (client)
+ {
+ fd = debuginfod_find_source (client, build_id, 0, fn, NULL);
+ debuginfod_end (client);
+ }
+ free (build_id);
+ }
}
#endif
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-26 5:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 5:07 PR29720, objdump -S crashes if build-id is missing Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).