From: Mike Frysinger <vapier@gentoo.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH, V2 10/15] gdb: sim: buildsystem changes to accommodate libsframe
Date: Thu, 27 Oct 2022 23:21:29 +0545 [thread overview]
Message-ID: <Y1rBncXBqj07wT/7@vapier> (raw)
In-Reply-To: <20221017221612.495324-11-indu.bhagat@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 17 Oct 2022 15:16, Indu Bhagat via Binutils wrote:
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -2167,6 +2167,17 @@ fi
> AC_SUBST(LIBCTF)
> AC_SUBST(CTF_DEPS)
>
> +GCC_ENABLE([libsframe], [yes], [], [Handle .sframe sections])
> +if test x${enable_static} = xno; then
> + LIBSFRAME="-Wl,--rpath,../libsframe/.libs ../libsframe/.libs/libsframe.so"
> + SFRAME_DEPS="../libsframe/.libs/libsframe.so"
> +else
> + LIBSFRAME="../libsframe/.libs/libsframe.a"
> + SFRAME_DEPS="$LIBSFRAME"
> +fi
this logic is not portable. you're using libtool to generate this library,
but then trying to go behind its back and hardcode paths that only libtool
is supposed to know about.
the "libsframe.so" path doesn't work on macOS, Windows, etc...
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-27 18:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 22:15 [PATCH,V2 00/15] Definition and support for SFrame unwind format Indu Bhagat
2022-10-17 22:15 ` [PATCH,V2 01/15] sframe.h: Add SFrame format definition Indu Bhagat
2022-10-17 22:15 ` [PATCH,V2 02/15] gas: add new command line option --gsframe Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 03/15] gas: generate .sframe from CFI directives Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 04/15] gas: testsuite: add new tests for SFrame unwind info Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 05/15] libsframe: add the SFrame library Indu Bhagat
2022-10-27 18:07 ` Mike Frysinger
2022-10-30 7:37 ` Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 06/15] bfd: linker: merge .sframe sections Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 07/15] readelf/objdump: support for SFrame section Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 08/15] unwinder: generate backtrace using SFrame format Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 09/15] unwinder: Add SFrame unwinder tests Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 10/15] gdb: sim: buildsystem changes to accommodate libsframe Indu Bhagat
2022-10-27 17:36 ` Mike Frysinger [this message]
2022-10-30 7:16 ` [PATCH, V2 " Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 11/15] libctf: add libsframe to LDFLAGS and LIBS Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 12/15] src-release.sh: Add libsframe Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 13/15] binutils/NEWS: add text for SFrame support Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 14/15] gas/NEWS: add text about new command line option and " Indu Bhagat
2022-10-17 22:16 ` [PATCH,V2 15/15] doc: add SFrame spec file Indu Bhagat
2022-10-21 10:52 ` [PATCH,V2 00/15] Definition and support for SFrame unwind format Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1rBncXBqj07wT/7@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).