From: Alan Modra <amodra@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/2] ld: Add publics stream to PDB files
Date: Fri, 28 Oct 2022 11:56:34 +1030 [thread overview]
Message-ID: <Y1svynHiN6+Cs5GG@squeak.grove.modra.org> (raw)
In-Reply-To: <20221027190052.10536-2-mark@harmstone.com>
On Thu, Oct 27, 2022 at 08:00:52PM +0100, Mark Harmstone wrote:
> + einfo (_("%P: warning: cannot create symbol record stream "
> + "in PDB file: %s\n"), bfd_errmsg (bfd_get_error ()));
You can use %E here and elsewhere rather than %s with bfd_errmsg.
With that tweak the patches both look OK to commit.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-10-28 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 19:00 [PATCH 1/2] ld: Add section header " Mark Harmstone
2022-10-27 19:00 ` [PATCH 2/2] ld: Add publics " Mark Harmstone
2022-10-28 1:26 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1svynHiN6+Cs5GG@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).