From: Alan Modra <amodra@gmail.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld/testsuite: skip ld-size when -shared is not supported
Date: Thu, 10 Nov 2022 19:30:34 +1030 [thread overview]
Message-ID: <Y2y9skmQ8ebfPCC6@squeak.grove.modra.org> (raw)
In-Reply-To: <CAJ307EgDJ_WLyhDYtbcb0vtrKC4VYBx7nDApPhrUU0F5BNEoHg@mail.gmail.com>
On Thu, Nov 10, 2022 at 08:54:04AM +0100, Clément Chigot wrote:
> On Wed, Nov 9, 2022 at 10:37 PM Alan Modra <amodra@gmail.com> wrote:
> >
> > On Wed, Nov 09, 2022 at 05:26:11PM +0100, Clément Chigot via Binutils wrote:
> > > * testsuite/ld-size/size.exp: Skip when -shared is not
> > > supported.
> >
> > What does this catch that isn't already covered by the target test?
>
> It does in a wide approach. But it doesn't allow custom targets (as I
> do) where shared support is explicitly disabled.
> It might not have a big impact but it looks logical to me to check for
> -shared (both linker and compiler by the way) before running any tests
> related to that.
> I've pushed other similar patches recently (see ld-arm or ld-shared).
OK, the patch is fine.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-11-10 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 16:26 Clément Chigot
2022-11-09 21:37 ` Alan Modra
2022-11-10 7:54 ` Clément Chigot
2022-11-10 9:00 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2y9skmQ8ebfPCC6@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).