From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: asan: NULL deref in filter_symbols
Date: Wed, 23 Nov 2022 22:58:19 +1030 [thread overview]
Message-ID: <Y34R4z7auiQd9V9m@squeak.grove.modra.org> (raw)
If tdata->symbols is NULL, make tdata->symcount zero too. This makes
wasm_get_symtab_upper_bound return the proper result and stops
cascading errors.
* wasm-module.c (wasm_scan_name_function_section): Clear
tdata->symcount on error.
diff --git a/bfd/wasm-module.c b/bfd/wasm-module.c
index 2c2c6c72863..c96665b6e91 100644
--- a/bfd/wasm-module.c
+++ b/bfd/wasm-module.c
@@ -359,6 +359,7 @@ wasm_scan_name_function_section (bfd *abfd, sec_ptr asect)
error_return:
if (symbols)
bfd_release (abfd, symbols);
+ tdata->symcount = 0;
return false;
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-11-23 12:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y34R4z7auiQd9V9m@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).