From: Alan Modra <amodra@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Mark Harmstone <mark@harmstone.com>, binutils@sourceware.org
Subject: Re: [PATCH] ld/testsuite: Fix test failures in pe.exp caused by 8819b236
Date: Thu, 5 Jan 2023 22:07:43 +1030 [thread overview]
Message-ID: <Y7a2hyLZaitwLpgr@squeak.grove.modra.org> (raw)
In-Reply-To: <cb87d6c7-723c-ace5-08f6-19534ca99d31@redhat.com>
On Thu, Jan 05, 2023 at 08:21:35AM +0000, Nick Clifton via Binutils wrote:
> Hi Mark,
>
> > This fixes three test failures caused by the change in .idata alignment
> > on x86_64-w64-mingw32.
> >
> > The secrel and secidx tests were dumping .idata, so this is easy enough
> > to solve - it's irrelevant to the tests anyway.
> >
> > As for the CFI test, it looks like the debug_frame code inserts an empty
> > entry at the beginning to pad this to an 8-byte boundary, so I've
> > changed the section alignment for the test to fix this.
>
> Patch approved - please apply.
>
> Thanks for fixing this problem!
I already fixed this with commit 478eebf83198. I guess I should put
it on the branch too.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2023-01-05 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:27 Mark Harmstone
2023-01-05 7:39 ` Jan Beulich
2023-01-05 8:21 ` Nick Clifton
2023-01-05 11:37 ` Alan Modra [this message]
2023-01-05 11:58 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7a2hyLZaitwLpgr@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).