public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Mark Harmstone <mark@harmstone.com>, binutils@sourceware.org
Subject: Re: [PATCH] ld/testsuite: Fix test failures in pe.exp caused by 8819b236
Date: Thu, 5 Jan 2023 08:21:35 +0000	[thread overview]
Message-ID: <cb87d6c7-723c-ace5-08f6-19534ca99d31@redhat.com> (raw)
In-Reply-To: <20230105002743.25019-1-mark@harmstone.com>

Hi Mark,

> This fixes three test failures caused by the change in .idata alignment
> on x86_64-w64-mingw32.
> 
> The secrel and secidx tests were dumping .idata, so this is easy enough
> to solve - it's irrelevant to the tests anyway.
> 
> As for the CFI test, it looks like the debug_frame code inserts an empty
> entry at the beginning to pad this to an 8-byte boundary, so I've
> changed the section alignment for the test to fix this.

Patch approved - please apply.

Thanks for fixing this problem!

Cheers
   Nick



  parent reply	other threads:[~2023-01-05  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  0:27 Mark Harmstone
2023-01-05  7:39 ` Jan Beulich
2023-01-05  8:21 ` Nick Clifton [this message]
2023-01-05 11:37   ` Alan Modra
2023-01-05 11:58     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb87d6c7-723c-ace5-08f6-19534ca99d31@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=mark@harmstone.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).