From: Mike Frysinger <vapier@gentoo.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] bfd: Properly install library and header files
Date: Sun, 23 Jan 2022 12:43:01 -0500 [thread overview]
Message-ID: <Ye2TpWFUL3RWqcdF@vapier> (raw)
In-Reply-To: <20220123153652.1130563-1-hjl.tools@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
On 23 Jan 2022 07:36, H.J. Lu via Binutils wrote:
> Rename bfdlib_LTLIBRARIES and bfdinclude_HEADERS to lib_LTLIBRARIES and
> include_HEADERS to fix the missing installed library and header files in
> bfd caused by
your patch below does two things: renames the vars and deletes an install
target. pretty sure only the latter is necessary to fix things. although
i don't know the history behind why bfd uses these names.
> --- a/bfd/Makefile.am
> +++ b/bfd/Makefile.am
> @@ -36,14 +36,14 @@ libbfd_la_LDFLAGS =
> if INSTALL_LIBBFD
> bfdlibdir = @bfdlibdir@
> bfdincludedir = @bfdincludedir@
> -bfdlib_LTLIBRARIES = libbfd.la
> -bfdinclude_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
> - $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h
> +lib_LTLIBRARIES = libbfd.la
> +include_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
> + $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h
> else !INSTALL_LIBBFD
> # Empty these so that the respective installation directories will not be created.
> bfdlibdir =
> bfdincludedir =
> -bfdinclude_HEADERS =
> +include_HEADERS =
> rpath_bfdlibdir = @bfdlibdir@
> noinst_LTLIBRARIES = libbfd.la
> libbfd_la_LDFLAGS += -rpath $(rpath_bfdlibdir)
there's stale comments in here now, as well as unused vars. the only reason
bfdincludedir was defined was because bfdinclude_HEADERS was too.
i think you should revert the bfd/Makefile.am changes and only keep the fix
to doc/local.mk.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-23 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 15:36 H.J. Lu
2022-01-23 17:43 ` Mike Frysinger [this message]
2022-01-23 18:03 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye2TpWFUL3RWqcdF@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).