public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: pe_ILF_make_a_symbol_reloc segfault
Date: Wed, 16 Feb 2022 22:03:34 +1030	[thread overview]
Message-ID: <YgzhDnprSx9Rlk2O@squeak.grove.modra.org> (raw)

pei-aarch64-little apparently lacks support for BFD_RELOC_RVA.

	* peicode.h (pe_ILF_make_a_symbol_reloc): Don't segfault on
	NULL howto.

diff --git a/bfd/peicode.h b/bfd/peicode.h
index bbf44813a75..0346bc2174e 100644
--- a/bfd/peicode.h
+++ b/bfd/peicode.h
@@ -489,7 +489,7 @@ pe_ILF_make_a_symbol_reloc (pe_ILF_vars *		vars,
 
   internal->r_vaddr  = address;
   internal->r_symndx = sym_index;
-  internal->r_type   = entry->howto->type;
+  internal->r_type   = entry->howto ? entry->howto->type : 0;
 
   vars->relcount ++;
 

-- 
Alan Modra
Australia Development Lab, IBM

                 reply	other threads:[~2022-02-16 11:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgzhDnprSx9Rlk2O@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).