From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] ld: Add a before_plugin_all_symbols_read hook
Date: Thu, 10 Mar 2022 11:50:44 +1030 [thread overview]
Message-ID: <YilSbE011B73spnK@squeak.grove.modra.org> (raw)
In-Reply-To: <20220308172230.135655-1-hjl.tools@gmail.com>
On Tue, Mar 08, 2022 at 09:22:30AM -0800, H.J. Lu via Binutils wrote:
> Add a before_plugin_all_symbols_read hook to load symbol references from
> DT_NEEDED entries, included from --copy-dt-needed-entries, before reading
> plugin symbols to properly resolve plugin symbol references.
OK, except
> * elf-bfd.h (elf_link_hash_table): Add
> before_plugin_all_symbols_read.
please change the name of this flag to better reflect what it does.
"handling_dt_needed" perhaps. You set and clear the flag around the
new ldelf_handle_dt_needed function. It isn't set before
plugin_call_all_symbols_read and clear afterwards.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-03-10 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 17:22 H.J. Lu
2022-03-10 1:20 ` Alan Modra [this message]
2022-03-10 2:23 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YilSbE011B73spnK@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).