Re: GDB 12.0.90 available for testing

Re: GDB 12.0.90 available for testing

[Joel Brobecker]

Adding binutils@ to the list, since opcode is part of binutils.

Can someone take a look at Luis' patch below, please? Luis noticed
this when he tried to build the GDB 12 release candidate with
--enable-target=all.

Thank you!

On Wed, Apr 13, 2022 at 06:20:24PM +0200, Jose E. Marchesi wrote:
> 
> > This particular combination of switches and host has not been built in
> > a while, so bugs might've been introduced/uncovered.
> >
> > Mike, Jose, does this look reasonable?
> 
> Sure, for BPF.
> 
> I wonder how we missed TARGET32_LIBOCODES_CFILES back when we integrated
> the bpf backend...
> 
> Thanks for fixing this.
> 
> > From 387ef2492403c89ac7ac817488a49a3fd7d9d4ba Mon Sep 17 00:00:00 2001
> > From: Luis Machado <luis.machado@arm.com>
> > Date: Wed, 13 Apr 2022 11:39:36 +0100
> > Subject: [PATCH] Fix 32-bit build for --enable-targets=all
> >
> > The following fixes the GDB build for 32-bit (tested on 32-bit arm)
> > for the following combinations:
> >
> > * --enable-targets=all --disable-sim
> > * --enable-targets=all
> >
> > I do see quite a few internal errors when running
> > gdb.base/all-architectures.exp on arm 32-bit Ubuntu 18.04. They all
> > fail when checking for a default disassembling function, which doesn't
> > exists for some targets.
> >
> > This particular combination of switches has not been tested for 32-bit
> > hosts in a while (since November/December 2021), so there might be bugs
> > that we need to address. The patch makes things build cleanly though.
> >
> > Tested on aarch64-linux Ubuntu 20.04 and armhf-linux-gnueabi Ubuntu 18.04.
> >
> > It would be nice to exercise this on other 32-bit targets.
> > ---
> >  opcodes/Makefile.am | 10 ++++++++++
> >  opcodes/Makefile.in | 10 ++++++++++
> >  2 files changed, 20 insertions(+)
> >
> > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am
> > index afd19fa7785..681fbc07584 100644
> > --- a/opcodes/Makefile.am
> > +++ b/opcodes/Makefile.am
> > @@ -124,6 +124,11 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	arm-dis.c \
> >  	avr-dis.c \
> >  	bfin-dis.c \
> > +	bpf-asm.c \
> > +	bpf-desc.c \
> > +	bpf-dis.c \
> > +	bpf-ibld.c \
> > +	bpf-opc.c \
> >  	cgen-asm.c \
> >  	cgen-bitset.c \
> >  	cgen-dis.c \
> > @@ -178,6 +183,9 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	lm32-ibld.c \
> >  	lm32-opc.c \
> >  	lm32-opinst.c \
> > +	loongarch-opc.c \
> > +	loongarch-dis.c \
> > +	loongarch-coder.c \
> >  	m10200-dis.c \
> >  	m10200-opc.c \
> >  	m10300-dis.c \
> > @@ -234,6 +242,8 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	ppc-opc.c \
> >  	pru-dis.c \
> >  	pru-opc.c \
> > +	riscv-dis.c \
> > +	riscv-opc.c \
> >  	rl78-decode.c \
> >  	rl78-dis.c \
> >  	rx-decode.c \
> > diff --git a/opcodes/Makefile.in b/opcodes/Makefile.in
> > index 3ab8bfb0548..d3eee49b169 100644
> > --- a/opcodes/Makefile.in
> > +++ b/opcodes/Makefile.in
> > @@ -516,6 +516,11 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	arm-dis.c \
> >  	avr-dis.c \
> >  	bfin-dis.c \
> > +	bpf-asm.c \
> > +	bpf-desc.c \
> > +	bpf-dis.c \
> > +	bpf-ibld.c \
> > +	bpf-opc.c \
> >  	cgen-asm.c \
> >  	cgen-bitset.c \
> >  	cgen-dis.c \
> > @@ -570,6 +575,9 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	lm32-ibld.c \
> >  	lm32-opc.c \
> >  	lm32-opinst.c \
> > +	loongarch-opc.c \
> > +	loongarch-dis.c \
> > +	loongarch-coder.c \
> >  	m10200-dis.c \
> >  	m10200-opc.c \
> >  	m10300-dis.c \
> > @@ -626,6 +634,8 @@ TARGET32_LIBOPCODES_CFILES = \
> >  	ppc-opc.c \
> >  	pru-dis.c \
> >  	pru-opc.c \
> > +	riscv-dis.c \
> > +	riscv-opc.c \
> >  	rl78-decode.c \
> >  	rl78-dis.c \
> >  	rx-decode.c \

-- 
Joel

Re: GDB 12.0.90 available for testing

[Alan Modra]

On Sun, Apr 17, 2022 at 10:33:59AM -0700, Joel Brobecker via Binutils wrote:
> Adding binutils@ to the list, since opcode is part of binutils.
> On Wed, Apr 13, 2022 at 06:20:24PM +0200, Jose E. Marchesi wrote:
> > > From: Luis Machado <luis.machado@arm.com>
> > > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am
> > > index afd19fa7785..681fbc07584 100644
> > > --- a/opcodes/Makefile.am
> > > +++ b/opcodes/Makefile.am
> > > @@ -124,6 +124,11 @@ TARGET32_LIBOPCODES_CFILES = \
> > >  	arm-dis.c \
> > >  	avr-dis.c \
> > >  	bfin-dis.c \
> > > +	bpf-asm.c \
> > > +	bpf-desc.c \
> > > +	bpf-dis.c \
> > > +	bpf-ibld.c \
> > > +	bpf-opc.c \
> > >  	cgen-asm.c \
> > >  	cgen-bitset.c \
> > >  	cgen-dis.c \

Anything that requires 64-bit BFD support does not belong in
TARGET32_LIBOPCODES_CFILES.  In fact, the whole point of
TARGET32_LIBOPCODES_CFILES was to fix --enable-targets=all breakage on
32-bit hosts without --enable-64-bit-bfd.  Why would you want to put
bpf here?  It's a 64-bit target!

-- 
Alan Modra
Australia Development Lab, IBM