From: Alan Modra <amodra@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: gas: set_symtab()'s setting of BSF_KEEP
Date: Wed, 4 May 2022 19:06:43 +0930 [thread overview]
Message-ID: <YnJJK4wnvs7AN+Ox@squeak.grove.modra.org> (raw)
In-Reply-To: <a63dfa54-33bb-993a-cba1-92860c674d80@suse.com>
On Wed, May 04, 2022 at 10:54:25AM +0200, Jan Beulich wrote:
> Alan,
>
> while looking into how to address an Arm64 regression I ended up
> coming across this code, originating from commit 76d129399558. The
> first thing that puzzled me was the != for checking BSF_SECTION_SYM.
The test is to prevent any attempt to change the const global_syms[].
That's why flags != BSF_SECTION_SYM is quite OK. It would be cleaner
to write a bfd_is_const_symbol similar to bfd_is_const_section.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-05-04 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 8:54 Jan Beulich
2022-05-04 9:36 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnJJK4wnvs7AN+Ox@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).