From: Alan Modra <amodra@gmail.com>
To: Dmitry Selyutin <ghostmansd@gmail.com>
Cc: binutils@sourceware.orglukekennethcasson, Leighton <lkcl@lkcl.net>
Subject: Re: [PATCH 0/2] extend opindex and fx_pcrel_adjust to 16 bits
Date: Wed, 25 May 2022 12:11:11 +0930 [thread overview]
Message-ID: <Yo2XRwYGN3axyAa8@squeak.grove.modra.org> (raw)
In-Reply-To: <CAMqzjevA57iVFgo9zPFA7aN03KO4s3ABCfw-pRUshdBDu8Pw2Q@mail.gmail.com>
On Wed, May 25, 2022 at 12:09:15AM +0300, Dmitry Selyutin wrote:
> Hello all, just in case the previous message was missed, I'd like to ping
> about the patches again.
Sorry, I haven't been very active over the last few weeks. I'm about
to apply the ppc_opindex_t patches, squashed into one, and your isel
patch. I've made some comment changes, plus gone back to masking
fx_pcrel_adjust, the reason being that if someone needed to reduce
fx_pcrel_adjust to, say, 12 bits to accomodate some new struct fix
field, they could do so with only a change to PPC_OPINDEX_MAX in the
ppc target code. A cast to ppc_opindex_t wouldn't work in that
situation I believe, you'd get the 12-bit signed value being extended
to an int, then masked to 16 bits by the cast.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-05-25 2:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:59 Dmitry Selyutin
2022-05-12 7:32 ` [PATCH v2 1/2] ppc: extend opindex " Dmitry Selyutin
2022-05-12 7:32 ` [PATCH v2 2/2] gas/write: extend fx_pcrel_adjust " Dmitry Selyutin
2022-05-17 11:20 ` [PATCH 0/2] extend opindex and " Dmitry Selyutin
2022-05-24 21:09 ` Dmitry Selyutin
2022-05-25 2:41 ` Alan Modra [this message]
2022-05-25 4:11 ` Dmitry Selyutin
2022-05-25 4:32 ` Alan Modra
2022-05-25 4:35 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo2XRwYGN3axyAa8@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.orglukekennethcasson \
--cc=ghostmansd@gmail.com \
--cc=lkcl@lkcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).