From: Alan Modra <amodra@gmail.com>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
Jan Beulich <jbeulich@suse.com>,
"George, Jini Susan" <JiniSusan.George@amd.com>,
"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
"Natarajan, Kavitha" <Kavitha.Natarajan@amd.com>
Subject: Re: [PATCH V2] bfd: Add Support for DW_FORM_strx* and DW_FORM_addrx*.
Date: Thu, 26 May 2022 16:32:21 +0930 [thread overview]
Message-ID: <Yo8l/eYMemE4Jtuw@squeak.grove.modra.org> (raw)
In-Reply-To: <DM6PR12MB4219E874BEBD0D535758D89EE7D79@DM6PR12MB4219.namprd12.prod.outlook.com>
Thanks for the patch. I'm going to commit it with some formatting
fixes, and a few improvements.
- reread_attribute no longer copies its attr arg.
- str_addrp is alloc'd in chunks, not on each addition.
- error paths out of parse_comp_unit free str_addrp.
- variables used as offset into arrays are now size_t.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-05-26 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 0:01 Potharla, Rupesh
2022-05-26 7:02 ` Alan Modra [this message]
2022-05-26 16:42 ` Potharla, Rupesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo8l/eYMemE4Jtuw@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=Hariharan.Parasuraman@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Kavitha.Natarajan@amd.com \
--cc=Rupesh.Potharla@amd.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).