From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: bit-rot in target before_parse function option
Date: Thu, 26 May 2022 20:36:56 +0930 [thread overview]
Message-ID: <Yo9fUA3rqk5ITTFN@squeak.grove.modra.org> (raw)
In-Reply-To: <Yodqagtj541XFsJo@squeak.grove.modra.org>
On Fri, May 20, 2022 at 07:46:10PM +0930, Alan Modra wrote:
> On Fri, May 20, 2022 at 09:07:06AM +0200, Clément Chigot wrote:
> > However, the testsuite changes look mandatory to me.
> > As of now, the results are different dependending on the
> > configure options being passed.
>
> Yes, you may well be correct. I'm going to leave this to Nick.
> Incidentally, the reason why I didn't fix the arm/aarch64 regressions
> is that if
>
> link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE;
> link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK;
> link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS;
> link_info.default_execstack = DEFAULT_LD_EXECSTACK;
>
> is added to armelf.em:before_parse then we get
>
> FAIL: PR ld/29072 (ignore absent .note.GNU-stack)
>
> The reason being that arm is listed in ld/testsuite/ld-elf/elf.exp
> target_defaults_to_execstack but doesn't have
> elf_backend_default_execstack set.
I guess I really shouldn't just palm this off to Nick, leaving
testsuite regressions.
Copy initialisation over from the elf.em before_parse. Commit
ba951afb999 2022-05-03 changed behaviour on arm and score regarding
exec stack. This patch restores the previous behaviour.
* emultempl/aarch64elf.em (before_parse): Init separate_code,
warn_execstack, no_warn_rwx_segments and default_execstack.
* emultempl/armelf.em (before_parse): Likewise.
* emultempl/scoreelf.em (before_parse): Likewise.
* testsuite/ld-elf/elf.exp (target_defaults_to_execstack): Return
true for arm and nacl.
diff --git a/ld/emultempl/aarch64elf.em b/ld/emultempl/aarch64elf.em
index 26e3dd243fc..1968f12cf29 100644
--- a/ld/emultempl/aarch64elf.em
+++ b/ld/emultempl/aarch64elf.em
@@ -54,6 +54,10 @@ fragment <<EOF
EOF
fi
fragment <<EOF
+ link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE;
+ link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK;
+ link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS;
+ link_info.default_execstack = DEFAULT_LD_EXECSTACK;
}
static void
diff --git a/ld/emultempl/armelf.em b/ld/emultempl/armelf.em
index 885067fa256..8f5334df198 100644
--- a/ld/emultempl/armelf.em
+++ b/ld/emultempl/armelf.em
@@ -67,6 +67,10 @@ fragment <<EOF
EOF
fi
fragment <<EOF
+ link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE;
+ link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK;
+ link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS;
+ link_info.default_execstack = DEFAULT_LD_EXECSTACK;
}
static void
diff --git a/ld/emultempl/scoreelf.em b/ld/emultempl/scoreelf.em
index f5dd06246de..d781dd96057 100644
--- a/ld/emultempl/scoreelf.em
+++ b/ld/emultempl/scoreelf.em
@@ -47,6 +47,10 @@ fragment <<EOF
EOF
fi
fragment <<EOF
+ link_info.separate_code = DEFAULT_LD_Z_SEPARATE_CODE;
+ link_info.warn_execstack = DEFAULT_LD_WARN_EXECSTACK;
+ link_info.no_warn_rwx_segments = ! DEFAULT_LD_WARN_RWX_SEGMENTS;
+ link_info.default_execstack = DEFAULT_LD_EXECSTACK;
}
static void
diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index ebb5ba090bf..621d4e121d7 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -182,8 +182,6 @@ if { [check_gc_sections_available] && ![istarget "v850-*-*"] } {
proc target_defaults_to_execstack {} {
if { [istarget "aarch64*-*-*"]
- || [istarget "arm*-*-*"]
- || [istarget "*-*-nacl"]
|| [istarget "arc*-*-*"]
|| [istarget "ia64*-*-*"]
|| [istarget "nios2*-*-*"]
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-05-26 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:51 [PATCH] ld: harmonize the value of --enable-warn-execstack=no option Clément Chigot
2022-05-20 5:54 ` Alan Modra
2022-05-20 6:45 ` Alan Modra
2022-05-20 7:07 ` Clément Chigot
2022-05-20 10:16 ` Alan Modra
2022-05-26 11:06 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo9fUA3rqk5ITTFN@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).