From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Re: ubsan: undefined shift in frag_align_code
Date: Fri, 3 Jun 2022 22:53:24 +0930 [thread overview]
Message-ID: <YpoLTNaoeJLIEs3K@squeak.grove.modra.org> (raw)
In-Reply-To: <Ypho865Bp3hca0ie@squeak.grove.modra.org>
This one needs the same fix too.
* config/tc-i386.h (MAX_MEM_FOR_RS_ALIGN_CODE): Avoid signed
integer overflow.
diff --git a/gas/config/tc-i386.h b/gas/config/tc-i386.h
index d7c6b33c778..817539ea560 100644
--- a/gas/config/tc-i386.h
+++ b/gas/config/tc-i386.h
@@ -207,7 +207,8 @@ if ((n) \
goto around; \
}
-#define MAX_MEM_FOR_RS_ALIGN_CODE (alignment ? ((1 << alignment) - 1) : 1)
+#define MAX_MEM_FOR_RS_ALIGN_CODE \
+ (alignment ? ((size_t) 1 << alignment) - 1 : (size_t) 1)
extern void i386_cons_align (int);
#define md_cons_align(nbytes) i386_cons_align (nbytes)
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-06-03 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 7:38 Alan Modra
2022-06-03 13:23 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpoLTNaoeJLIEs3K@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).