public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] binutils-gdb/git: highlight whitespace errors in source files
Date: Wed, 20 Jul 2022 11:18:57 +0930	[thread overview]
Message-ID: <YtdfCdOEkoBKCWf1@squeak.grove.modra.org> (raw)
In-Reply-To: <20220719142631.1882613-1-aburgess@redhat.com>

On Tue, Jul 19, 2022 at 03:26:31PM +0100, Andrew Burgess via Binutils wrote:
> For a long time I've had this in my ~/.gitconfig:
> 
>   [core]
>           whitespace = space-before-tab,indent-with-non-tab,trailing-space
> 
> which causes git to show me if I muck up and use spaces instead of
> tabs, or leave in trailing whitespace.  I find this really useful.

Same here.

> I recently proposed adding something like this to the .gitattributes
> files for the GDB sub-directories (gdb, gdbsupport, and gdbserver)[1],
> however, the question was asked - couldn't this be done at the top
> level?

I'm happy with your patch.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2022-07-20  1:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 14:26 Andrew Burgess
2022-07-20  1:48 ` Alan Modra [this message]
2022-07-25 13:37   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtdfCdOEkoBKCWf1@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).