From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: PR15951, binutils testsuite builds status wrapper unconditionally
Date: Fri, 22 Jul 2022 11:58:36 +0930 [thread overview]
Message-ID: <YtoLVGH7vgdZ6j9C@squeak.grove.modra.org> (raw)
This bug has been sitting in bugzilla, with a patch (different to this
one, I'm copying from gdb) for 3234 days. Which says we don't have
enough competent people looking at bugzilla. Please help out if you
can.
PR 15951
* testsuite/binutils-all/objcopy.exp: Build testglue.o when
needs_status_wrapper.
diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index 9a5dad5384e..5871d431eea 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -641,7 +641,12 @@ proc copy_setup { } {
global test_prog
global host_triplet
- set res [build_wrapper testglue.o]
+ if {[target_info exists needs_status_wrapper] && \
+ [target_info needs_status_wrapper] != "0"} {
+ set res [build_wrapper testglue.o]
+ } else {
+ set res ""
+ }
set flags { debug }
if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] && ![istarget arm*-*-uclinuxfdpiceabi] } {
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-07-22 2:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtoLVGH7vgdZ6j9C@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).