From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: ubsan: arm-dis.c index out of bounds
Date: Wed, 14 Sep 2022 10:09:19 +0930 [thread overview]
Message-ID: <YyEit0hKueDyLNsW@squeak.grove.modra.org> (raw)
We are way off in the weeds with this one, and will be printing
<UNPREDICTABLE> for S > 10, so I think wrapping the register number is
fine. Found by fuzzers.
* arm-dis.c (print_insn_cde): Wrap 'T' value.
diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index c1bf276b423..684c74f7f20 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -8957,7 +8957,7 @@ print_insn_cde (struct disassemble_info *info, long given, bool thumb)
break;
case 'T':
- func (stream, "%s", arm_regnames[value + 1]);
+ func (stream, "%s", arm_regnames[(value + 1) & 15]);
break;
case 'd':
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-09-14 0:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyEit0hKueDyLNsW@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).