public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* ubsan: arm-dis.c index out of bounds
@ 2022-09-14  0:39 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2022-09-14  0:39 UTC (permalink / raw)
  To: binutils

We are way off in the weeds with this one, and will be printing
<UNPREDICTABLE> for S > 10, so I think wrapping the register number is
fine.  Found by fuzzers.

	* arm-dis.c (print_insn_cde): Wrap 'T' value.

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index c1bf276b423..684c74f7f20 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -8957,7 +8957,7 @@ print_insn_cde (struct disassemble_info *info, long given, bool thumb)
 		    break;
 
 		  case 'T':
-		    func (stream, "%s", arm_regnames[value + 1]);
+		    func (stream, "%s", arm_regnames[(value + 1) & 15]);
 		    break;
 
 		  case 'd':

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-14  0:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14  0:39 ubsan: arm-dis.c index out of bounds Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).