From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: objdump segfault after symbol table error
Date: Tue, 14 Mar 2023 12:36:24 +1030 [thread overview]
Message-ID: <ZA/WoJ/0CrDmzojB@squeak.grove.modra.org> (raw)
This memcpy segfaults if symcount is -1 (=> syms is NULL).
memcpy (sorted_syms, symcount ? syms : dynsyms,
sorted_symcount * sizeof (asymbol *));
* objdump.c (slurp_symtab): Don't leave symcount as -1 after
an error.
(slurp_dynamic_symtab): Likewise for dynsymcount.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 0e8e1980b80..5dac13ba868 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -1015,6 +1015,7 @@ slurp_symtab (bfd *abfd)
my_bfd_nonfatal (bfd_get_filename (abfd));
free (sy);
sy = NULL;
+ symcount = 0;
}
return sy;
}
@@ -1048,6 +1049,7 @@ slurp_dynamic_symtab (bfd *abfd)
my_bfd_nonfatal (bfd_get_filename (abfd));
free (sy);
sy = NULL;
+ dynsymcount = 0;
}
return sy;
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-03-14 2:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA/WoJ/0CrDmzojB@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).