* PR30198, Assertion and segfault when linking x86_64 elf and coff
@ 2023-03-06 3:32 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-03-06 3:32 UTC (permalink / raw)
To: binutils
PR 30198
* coff-x86_64.c (coff_amd64_reloc): Set *error_message when
returning bfd_reloc_dangerous. Also check that __ImageBase is
defined before accessing h->u.def.
diff --git a/bfd/coff-x86_64.c b/bfd/coff-x86_64.c
index 13061cdacff..822504a339b 100644
--- a/bfd/coff-x86_64.c
+++ b/bfd/coff-x86_64.c
@@ -139,15 +139,19 @@ coff_amd64_reloc (bfd *abfd,
break;
case bfd_target_elf_flavour:
/* Subtract __ImageBase. */
+ h = NULL;
link_info = _bfd_get_link_info (obfd);
- if (link_info == NULL)
- return bfd_reloc_dangerous;
- h = bfd_link_hash_lookup (link_info->hash, "__ImageBase",
- false, false, false);
- if (h == NULL)
- return bfd_reloc_dangerous;
- while (h->type == bfd_link_hash_indirect)
- h = h->u.i.link;
+ if (link_info != NULL)
+ h = bfd_link_hash_lookup (link_info->hash, "__ImageBase",
+ false, false, true);
+ if (h == NULL
+ || (h->type != bfd_link_hash_defined
+ && h->type != bfd_link_hash_defweak))
+ {
+ *error_message
+ = (char *) _("R_AMD64_IMAGEBASE with __ImageBase undefined");
+ return bfd_reloc_dangerous;
+ }
/* ELF symbols in relocatable files are section relative,
but in nonrelocatable files they are virtual addresses. */
diff -= (h->u.def.value
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-06 3:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-06 3:32 PR30198, Assertion and segfault when linking x86_64 elf and coff Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).