* sh4-linux segfaults running ld testsuite
@ 2023-04-19 23:11 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-04-19 23:11 UTC (permalink / raw)
To: binutils
Segmentation fault
FAIL: pr22269-1 (static pie undefined weak)
and others running "visibility (hidden undef)" tests
No code has any right to access bfd_link_hash_entry u.def without
first checking the type, and SYMBOL_REFERENCES_LOCAL isn't sufficient.
* elf32-sh.c (sh_elf_finish_dynamic_symbol): Don't use relative
relocs in GOT unless symbol is defined.
diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c
index fdcc5870890..499233d1355 100644
--- a/bfd/elf32-sh.c
+++ b/bfd/elf32-sh.c
@@ -6174,6 +6174,8 @@ sh_elf_finish_dynamic_symbol (bfd *output_bfd, struct bfd_link_info *info,
The entry in the global offset table will already have been
initialized in the relocate_section function. */
if (bfd_link_pic (info)
+ && (h->root.type == bfd_link_hash_defined
+ || h->root.type == bfd_link_hash_defweak)
&& SYMBOL_REFERENCES_LOCAL (info, h))
{
if (htab->fdpic_p)
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-19 23:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-19 23:11 sh4-linux segfaults running ld testsuite Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).