public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: [GOLD, PowerPC64] Debug info relocation overflow
Date: Wed, 19 Jul 2023 11:12:10 +0930	[thread overview]
Message-ID: <ZLc/ckC/wa90hisa@squeak.grove.modra.org> (raw)

It is possible to build huge binaries on powerpc64, where 32-bit
addresses in debug info are insufficient to descibe locations in the
binary.  Help out the user, and only warn about debug overflows.

	* powerpc.cc (Target_powerpc::Relocate::relocate): Warn on
	relocation overflows in debug info.

diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index 96fef7b8dde..d62bdea7ecb 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -12420,10 +12420,19 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
 	       && gsym->is_undefined()
 	       && is_branch_reloc<size>(r_type))))
     {
-      gold_error_at_location(relinfo, relnum, rela.get_r_offset(),
-			     _("relocation overflow"));
-      if (has_stub_value)
-	gold_info(_("try relinking with a smaller --stub-group-size"));
+      if (os->flags() & elfcpp::SHF_ALLOC)
+	{
+	  gold_error_at_location(relinfo, relnum, rela.get_r_offset(),
+				 _("relocation overflow"));
+	  if (has_stub_value)
+	    gold_info(_("try relinking with a smaller --stub-group-size"));
+	}
+      else
+	{
+	  gold_warning_at_location(relinfo, relnum, rela.get_r_offset(),
+				   _("relocation overflow"));
+	  gold_info(_("debug info may be unreliable, compile with -gdwarf64"));
+	}
     }
 
   return true;

-- 
Alan Modra
Australia Development Lab, IBM

                 reply	other threads:[~2023-07-19  1:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLc/ckC/wa90hisa@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).