From: Alan Modra <amodra@gmail.com>
To: Oleg Tolmatcev <oleg.tolmatcev@gmail.com>
Cc: Nick Clifton <nickc@redhat.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH V3] optimize handle_COMDAT
Date: Tue, 1 Aug 2023 10:41:47 +0930 [thread overview]
Message-ID: <ZMhb01+UtiuM+YPr@squeak.grove.modra.org> (raw)
In-Reply-To: <CACcXsZidPrqhNYj1Jb4Ypj2e7rzKvLqXoCefSjBVRaX4nniw3w@mail.gmail.com>
On Mon, Jul 03, 2023 at 12:09:22AM +0200, Oleg Tolmatcev via Binutils wrote:
> Am Fr., 30. Juni 2023 um 14:08 Uhr schrieb Nick Clifton <nickc@redhat.com>:
> > Thank you. Unfortunately there are still a couple of problems
> > with the patch, Firstly, and most importantly, the patch triggers
> > a new failure in the linker testsuite:
> >
> > Running ld/testsuite/ld-linkonce/linkonce.exp ...
> > [...]
> > FAIL: pr26103
> >
>
> I have run "make check" in WSL and it passed. I then rebased the patch
> on top of master and ran "make check" in WSL again and it passed. I
> can not reproduce the failure. I develop on Windows, but I even ran it
> on my Linux machine with Manjaro Linux and it passed.
I applied your latest patch, and it results in failures as Nick said.
aarch64-pe +FAIL: pr26103
arm-pe +FAIL: pr26103
arm-wince-pe +FAIL: pr26103
i686-pe +FAIL: pr26103
mcore-pe +FAIL: pr26103
sh-pe +FAIL: pr26103
x86_64-w64-mingw32 +FAIL: pr26103
This is with mainline binutils built on x86_64-linux using
~/src/binutils-gdb/configure \
--disable-nls \
--disable-gdb --disable-gdbserver --disable-gdbsupport --disable-gprofng \
--disable-libbacktrace --disable-libdecnumber --disable-readline --disable-sim \
--enable-obsolete --target=$target
make && make check
I think something is wrong with your testing. In ld/ld.log for
x86_64-w64-mingw32 I see
./ld-new -o tmpdir/pr26103 -L/home/alan/src/binutils-gdb/ld/testsuite/ld-linkonce tmpdir/ref1.o --start-group tmpdir/sym.a tmpdir/ref2.o --end-group
Executing on host: sh -c {./ld-new -o tmpdir/pr26103 -L/home/alan/src/binutils-gdb/ld/testsuite/ld-linkonce tmpdir/ref1.o --start-group tmpdir/sym.a tmpdir/ref2.o --end-group 2>&1} /dev/null ld.tmp (timeout = 300)
spawn [open ...]
./ld-new: tmpdir/sym.a(sym2.o):fake:(.gnu.linkonce.d.foo[onex]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here
./ld-new: tmpdir/sym.a(sym3.o):fake:(.gnu.linkonce.d.foo[oney]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here
./ld-new: tmpdir/sym.a(sym2.o):fake:(.gnu.linkonce.d.foo[onex]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here
./ld-new: tmpdir/sym.a(sym3.o):fake:(.gnu.linkonce.d.foo[oney]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here
FAIL: pr26103
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2023-08-01 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 17:40 Oleg Tolmatcev
2023-06-30 12:08 ` Nick Clifton
2023-07-02 22:09 ` Oleg Tolmatcev
2023-07-31 21:31 ` Oleg Tolmatcev
2023-08-01 1:11 ` Alan Modra [this message]
2023-08-01 22:22 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMhb01+UtiuM+YPr@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=oleg.tolmatcev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).