* cris: sprintf sanitizer null destination pointer
@ 2023-08-03 11:43 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-08-03 11:43 UTC (permalink / raw)
To: binutils
Simplify the sprintf calls, and use sprintf return value. Older code
in binutils avoided using the sprintf return count of chars printed,
because with some older C libraries it wasn't reliable. Nowadays it
should be OK to use (and we already use the return value elsewhere).
sprintf can't return an error status of -1 here.
* cris-dis.c (format_dec): Avoid sanitizer warning. Use sprintf
return value rather than calling strlen.
diff --git a/opcodes/cris-dis.c b/opcodes/cris-dis.c
index b8eaa4b7942..681fccf0dca 100644
--- a/opcodes/cris-dis.c
+++ b/opcodes/cris-dis.c
@@ -580,12 +580,7 @@ static char *
format_dec (long number, char *outbuffer, int signedp)
{
last_immediate = number;
- if (signedp)
- sprintf (outbuffer, "%ld", number);
- else
- sprintf (outbuffer, "%lu", (unsigned long) number);
-
- return outbuffer + strlen (outbuffer);
+ return outbuffer + sprintf (outbuffer, signedp ? "%ld" : "%lu", number);
}
/* Format the name of the general register regno into outbuffer. */
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-03 11:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 11:43 cris: sprintf sanitizer null destination pointer Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).