From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH 0/5] aarch64 BTI stub fixes
Date: Tue, 7 Nov 2023 13:08:59 +0000 [thread overview]
Message-ID: <ZUo265GnIl8fdtwf@arm.com> (raw)
In-Reply-To: <a188aab4-0042-462c-94de-2e84d157e8ab@redhat.com>
The 11/07/2023 11:38, Nick Clifton wrote:
> Hi Szabolcs,
>
> > Large binaries with BTI can be linked incorrectly with
> > binutils 2.41 because PR30930.
> >
> > there are other less critical related issues fixed in
> > this patchset as well.
> >
> > Szabolcs Nagy (5):
> > bfd: aarch64: Fix BTI stub optimization PR30957
> > bfd: aarch64: Fix broken BTI stub PR30930
> > bfd: aarch64: Fix leaks in case of BTI stub reuse
> > bfd: aarch64: Avoid BTI stub for a PLT that has BTI
> > ld: aarch64: Add BTI stub insertion test PR30930
>
> This patch series looks good to me, so please apply if you have not already done so.
>
>
> FYI - I did find one regression in the linker testsuite with the patch applied:
>
> FAIL: Check linker stubs with indirect calls handle BTI (exe).
>
> However there are mitigating circumstances:
>
> * The failure was for an unusual toolchain configuration:
>
> --target=aarch64_be-linux-gnu_ilp32
>
> * The three other tests in this part of the testsuite also fail, both
> with and without your patch applied:
>
> FAIL: Check linker stubs with indirect calls handle BTI (shared lib).
> FAIL: Check linker stubs with indirect calls handle BTI (exe).
> FAIL: Check linker stubs with indirect calls handle BTI when target has BTI.
>
> Note: there appear to be *two* tests called "check linker stubs with indirect calls handle BTI (exe)."
>
> I leave it up to you to decide if it is worth fixing these tests.
thanks for looking at this.
i will have to check what's going on.
> PS. My gut feeling at the moment is that we do not need a 2.41.1 release
> for this patch, since AArch64 systems with BTI enabled are not yet the norm,
> and those that do exist are being used to test for problems like this rather
> than general use. Since your patch will be in the 2.42 release, due January
> next year, I think that that will be a reasonable timescale for getting the
> fix out there. Do you agree ?
makes sense,
unless it affects hardened kernel builds.
i will have to check if that's an issue.
thanks.
next prev parent reply other threads:[~2023-11-07 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 13:15 Szabolcs Nagy
2023-11-03 13:15 ` [PATCH 1/5] bfd: aarch64: Fix BTI stub optimization PR30957 Szabolcs Nagy
2023-11-03 13:15 ` [PATCH 2/5] bfd: aarch64: Fix broken BTI stub PR30930 Szabolcs Nagy
2023-11-03 13:15 ` [PATCH 3/5] bfd: aarch64: Fix leaks in case of BTI stub reuse Szabolcs Nagy
2023-11-03 13:15 ` [PATCH 4/5] bfd: aarch64: Avoid BTI stub for a PLT that has BTI Szabolcs Nagy
2023-11-03 13:22 ` [PATCH 5/5] ld: aarch64: Add BTI stub insertion test PR30930 Szabolcs Nagy
2023-11-03 13:15 ` Szabolcs Nagy
2023-11-07 11:38 ` [PATCH 0/5] aarch64 BTI stub fixes Nick Clifton
2023-11-07 13:08 ` Szabolcs Nagy [this message]
2023-11-09 14:58 ` Szabolcs Nagy
2023-11-17 8:42 ` Fangrui Song
[not found] ` <DS7PR12MB5765CE9DC452CD430E68B89BCBB7A@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-11-20 14:56 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUo265GnIl8fdtwf@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).