From: Alan Modra <amodra@gmail.com>
To: John David Anglin <dave@parisc-linux.org>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] Fix segmentation fault in bfd/elf32-hppa.c
Date: Wed, 13 Dec 2023 10:31:41 +1030 [thread overview]
Message-ID: <ZXj0ZTGUXZkMic0F@squeak.grove.modra.org> (raw)
In-Reply-To: <ZXiWmK19GVwZBsIX@mx3210.localdomain>
On Tue, Dec 12, 2023 at 05:21:28PM +0000, John David Anglin wrote:
> diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c
> index 44129c80138..131f6806aa7 100644
> --- a/bfd/elf32-hppa.c
> +++ b/bfd/elf32-hppa.c
> @@ -4216,7 +4216,7 @@ elf32_hppa_finish_dynamic_symbol (bfd *output_bfd,
> file, we just want to emit a RELATIVE reloc. The entry
> in the global offset table will already have been
> initialized in the relocate_section function. */
> - if (!is_dyn)
> + if (!is_dyn && eh->root.type != bfd_link_hash_undefined)
> {
> rela.r_info = ELF32_R_INFO (0, R_PARISC_DIR32);
> rela.r_addend = (eh->root.u.def.value
Since the code uses u.def here, it is better IMO to test explicitly
for either bfd_link_hash_defined or bfd_link_hash_defweak. I'm left
wondering whether there isn't some case where we get here with an
undefweak (or common, or new, or..) symbol.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2023-12-13 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:21 John David Anglin
2023-12-13 0:01 ` Alan Modra [this message]
2023-12-15 21:13 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXj0ZTGUXZkMic0F@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=dave@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).