* [PATCH] PPC64/ELF: adjust comment wrt ABI versions
@ 2024-01-05 8:31 Jan Beulich
2024-01-06 12:25 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2024-01-05 8:31 UTC (permalink / raw)
To: Binutils; +Cc: Alan Modra, Peter Bergner, Geoff Keating
While having been moved a couple of times since its introduction in
f6c7c3e8b742 ("Referencing a function's address on PowerPC64 ELFv2"),
the wording has always remained the same. In particular ELFv1 and ELFv2
have always been the wrong way round.
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -4498,7 +4498,7 @@ ppc64_elf_before_check_relocs (bfd *ibfd
{
/* For input files without an explicit abiversion in e_flags
we should have flagged any with symbol st_other bits set
- as ELFv1 and above flagged those with .opd as ELFv2.
+ as ELFv2 and above flagged those with .opd as ELFv1.
Set the output abiversion if not yet set, and for any input
still ambiguous, take its abiversion from the output.
Differences in ABI are reported later. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PPC64/ELF: adjust comment wrt ABI versions
2024-01-05 8:31 [PATCH] PPC64/ELF: adjust comment wrt ABI versions Jan Beulich
@ 2024-01-06 12:25 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2024-01-06 12:25 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils, Peter Bergner, Geoff Keating
On Fri, Jan 05, 2024 at 09:31:23AM +0100, Jan Beulich wrote:
> While having been moved a couple of times since its introduction in
> f6c7c3e8b742 ("Referencing a function's address on PowerPC64 ELFv2"),
> the wording has always remained the same. In particular ELFv1 and ELFv2
> have always been the wrong way round.
Thanks for the fix.
> --- a/bfd/elf64-ppc.c
> +++ b/bfd/elf64-ppc.c
> @@ -4498,7 +4498,7 @@ ppc64_elf_before_check_relocs (bfd *ibfd
> {
> /* For input files without an explicit abiversion in e_flags
> we should have flagged any with symbol st_other bits set
> - as ELFv1 and above flagged those with .opd as ELFv2.
> + as ELFv2 and above flagged those with .opd as ELFv1.
> Set the output abiversion if not yet set, and for any input
> still ambiguous, take its abiversion from the output.
> Differences in ABI are reported later. */
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-06 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-05 8:31 [PATCH] PPC64/ELF: adjust comment wrt ABI versions Jan Beulich
2024-01-06 12:25 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).