* PR23877, bad value (n32r5900) for default CPU
@ 2024-02-28 22:28 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2024-02-28 22:28 UTC (permalink / raw)
To: binutils
Catching this at configure time would be nicer, but we'd need to exactly
match mips_parse_cpu in configure.ac and keep it all in sync.
PR 23877
* config/tc-mips.c (mips_after_parse_args): Don't assert that
mips_parse_cpu returns non-NULL, call as_fatal with an informative
message instead.
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 43c12de2c8a..8f54cb8937a 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -15287,7 +15287,9 @@ mips_after_parse_args (void)
if (arch_info == 0)
{
arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
- gas_assert (arch_info);
+ if (!arch_info)
+ as_fatal (_("gas doesn't understand your configure target %s"),
+ TARGET_ALIAS);
}
if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-28 22:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 22:28 PR23877, bad value (n32r5900) for default CPU Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).