* [PATCH 0/3] arm: Fix encoding/disassembly of MVE vq[r]shr[u]n insns
@ 2024-04-03 10:52 Alex Coplan
2024-04-09 8:09 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Alex Coplan @ 2024-04-03 10:52 UTC (permalink / raw)
To: binutils; +Cc: Nick Clifton, Richard Earnshaw
This patch series fixes the encoding of vqshr[u]n insns which are
currently incorrectly encoded as the rounding vqrshr[u]n variants
(i.e. with the LSB set).
It also fixes the disassembly of both sets of insns (rounding and
non-rounding) where we currently fail to properly decode the immediate.
See patch 2/3 for a concrete of example of what goes wrong in both
cases.
The series is organised as follows:
- 1/3 is a non-functional refactoring that should make 3/3 easier to
review.
- 2/3 fixes the encoding of the non-rounding vqshr[u]n insns.
- 3/3 fixes the disassembly of the immediate for both sets of insns,
updates an existing (incorrect) test, and adds a test for the
non-rounding insns.
Tested as a series on arm-none-eabi, no regressions. OK for trunk and
backports?
Thanks,
Alex
Alex Coplan (3):
arm: Refactor condition for print_mve_shift_n
arm: Fix encoding of MVE vqshr[u]n
arm: Fix disassembly of MVE vq[r]shr[u]n
gas/config/tc-arm.c | 8 +-
gas/testsuite/gas/arm/mve-vqrshrn.d | 3616 +++++++++++++--------------
gas/testsuite/gas/arm/mve-vqshrn.d | 27 +
gas/testsuite/gas/arm/mve-vqshrn.s | 40 +
opcodes/arm-dis.c | 39 +-
5 files changed, 1908 insertions(+), 1822 deletions(-)
create mode 100644 gas/testsuite/gas/arm/mve-vqshrn.d
create mode 100644 gas/testsuite/gas/arm/mve-vqshrn.s
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/3] arm: Fix encoding/disassembly of MVE vq[r]shr[u]n insns
2024-04-03 10:52 [PATCH 0/3] arm: Fix encoding/disassembly of MVE vq[r]shr[u]n insns Alex Coplan
@ 2024-04-09 8:09 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-04-09 8:09 UTC (permalink / raw)
To: Alex Coplan, binutils; +Cc: Richard Earnshaw
Hi Alex,
> This patch series fixes the encoding of vqshr[u]n insns which are
> currently incorrectly encoded as the rounding vqrshr[u]n variants
> (i.e. with the LSB set).
>
> It also fixes the disassembly of both sets of insns (rounding and
> non-rounding) where we currently fail to properly decode the immediate.
> See patch 2/3 for a concrete of example of what goes wrong in both
> cases.
>
> The series is organised as follows:
> - 1/3 is a non-functional refactoring that should make 3/3 easier to
> review.
> - 2/3 fixes the encoding of the non-rounding vqshr[u]n insns.
> - 3/3 fixes the disassembly of the immediate for both sets of insns,
> updates an existing (incorrect) test, and adds a test for the
> non-rounding insns.
>
> Tested as a series on arm-none-eabi, no regressions. OK for trunk and
> backports?
Patch series approved for mainline and backports. Please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-09 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-03 10:52 [PATCH 0/3] arm: Fix encoding/disassembly of MVE vq[r]shr[u]n insns Alex Coplan
2024-04-09 8:09 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).