From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: mmix disassemble memory leak
Date: Fri, 19 Apr 2024 10:01:47 +0930 [thread overview]
Message-ID: <ZiG7c3XocvqsXBI2@squeak.grove.modra.org> (raw)
It's a once-off and of no consequence, but fix it anyway. The mmix
caonoicalize_syms array is an array of pointers. Freeing it won't
lose symbol names.
* mmix-dis.c (initialize_mmix_dis_info): Free syms.
diff --git a/opcodes/mmix-dis.c b/opcodes/mmix-dis.c
index ea17bfe974a..370da70ed5d 100644
--- a/opcodes/mmix-dis.c
+++ b/opcodes/mmix-dis.c
@@ -117,6 +117,7 @@ initialize_mmix_dis_info (struct disassemble_info *info)
&& minfop->reg_name[syms[i]->value] == NULL)
minfop->reg_name[syms[i]->value] = syms[i]->name;
}
+ free (syms);
}
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2024-04-19 0:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiG7c3XocvqsXBI2@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).